fix: address feedback

Author: zastrowm

src/strands/agent/agent.py

@@ -632,7 +632,6 @@ async def stream_async(
         # Conditionally acquire lock based on concurrent_invocation_mode
         # Using threading.Lock instead of asyncio.Lock because run_async() creates
         # separate event loops in different threads
-        lock_acquired = False
         if self._concurrent_invocation_mode == ConcurrentInvocationMode.THROW:
             lock_acquired = self._invocation_lock.acquire(blocking=False)
             if not lock_acquired:
@@ -687,7 +686,7 @@ async def stream_async(
                     raise
 
         finally:
-            if lock_acquired:
+            if self._invocation_lock.locked():
                 self._invocation_lock.release()
 
     async def _run_loop(

tests/strands/agent/test_agent.py

@@ -26,6 +26,7 @@
 from strands.session.repository_session_manager import RepositorySessionManager
 from strands.telemetry.tracer import serialize
 from strands.types._events import EventLoopStopEvent, ModelStreamEvent
+from strands.types.agent import ConcurrentInvocationMode
 from strands.types.content import Messages
 from strands.types.exceptions import ConcurrencyException, ContextWindowOverflowException, EventLoopException
 from strands.types.session import Session, SessionAgent, SessionMessage, SessionType
@@ -2235,16 +2236,13 @@ def test_agent_concurrent_call_raises_exception():
 
     results = []
     errors = []
-    lock = threading.Lock()
 
     def invoke():
         try:
             result = agent("test")
-            with lock:
-                results.append(result)
+            results.append(result)
         except ConcurrencyException as e:
-            with lock:
-                errors.append(e)
+            errors.append(e)
 
     # Start first thread and wait for it to begin streaming
     t1 = threading.Thread(target=invoke)
@@ -2384,7 +2382,6 @@ def test_agent_concurrent_invocation_mode_stores_value():
 
 def test_agent_concurrent_invocation_mode_accepts_enum():
     """Test that concurrent_invocation_mode accepts enum values as well as strings."""
-    from strands.types.agent import ConcurrentInvocationMode
 
     model = MockedModelProvider([{"role": "assistant", "content": [{"text": "hello"}]}])