Do not make RunPostTestChecks inherit from TestCase

Aside from the coinciding setUp and tearDown names, it has nothing to do
with a TestCase.

Signed-off-by: mulhern <amulhern@redhat.com>

Author: mulkieran

stratis_cli_cert.py

@@ -185,7 +185,6 @@ def setUp(self):
         super().setUp()
 
         self._post_test_checks = RunPostTestChecks()
-        self._post_test_checks.setUp()
 
     def tearDown(self):
         """
@@ -195,7 +194,7 @@ def tearDown(self):
         """
         super().tearDown()
 
-        self._post_test_checks.tearDown()
+        self._post_test_checks.teardown()
 
     def _test_permissions(self, command_line, permissions, exp_stdout_empty):
         """

stratisd_cert.py

@@ -181,7 +181,6 @@ def setUp(self):
         super().setUp()
 
         self._post_test_checks = RunPostTestChecks()
-        self._post_test_checks.setUp()
 
     def tearDown(self):
         """
@@ -191,7 +190,7 @@ def tearDown(self):
         """
         super().tearDown()
 
-        self._post_test_checks.tearDown()
+        self._post_test_checks.teardown()
 
     def _unittest_set_property(
         self, object_path, param_iface, dbus_param, dbus_value, exception_name

testlib/infra.py

@@ -597,16 +597,22 @@ def __str__(self):
         return self.value
 
 
-class RunPostTestChecks(unittest.TestCase):
+class RunPostTestChecks:
     """
     Manage running post test checks
     """
 
-    def setUp(self):
+    def __init__(self):
+        """
+        Set up checks that need to be started before test is run.
+        """
         self.dbus_monitor = DbusMonitor()
         self.dbus_monitor.setUp()
 
-    def tearDown(self):
+    def teardown(self):
+        """
+        Run post-test checks after test is completed.
+        """
         stop_time = time.monotonic_ns()
         self.dbus_monitor.run_check(stop_time)