webdriver_options: add explicit binary path on Windows, set --headless=new

Author: stanislaw

html2print/html2print.py

@@ -328,13 +328,27 @@ def create_webdriver(
         service = Service(path_to_chrome)
 
     webdriver_options = Options()
+
+    # Workaround for Windows: Chrome is not typically found in the PATH, so
+    # need to supply the exact binary location manually.
+    if platform.system() == "Windows":
+        webdriver_options.binary_location = path_to_chrome
+
     webdriver_options.add_argument("start-maximized")
     webdriver_options.add_argument("disable-infobars")
     # Doesn't seem to be needed.
     # webdriver_options.add_argument('--disable-gpu')  # noqa: ERA001
     webdriver_options.add_argument("--disable-extensions")
-    webdriver_options.add_argument("--headless=chrome")
-    # FIXME: This is not nice but otherwise it does not work in Ubuntu 24-based Docker image.
+
+    # Use --headless=new, as it seems to be more stable on Windows (available since Chrome 109).
+    # see https://www.selenium.dev/blog/2023/headless-is-going-away/
+    webdriver_options.add_argument("--headless=new")
+
+    # Docker disables some syscalls that are required for Chrome's sandbox to work.
+    # https://stackoverflow.com/questions/68855734/how-to-setup-chrome-sandbox-on-docker-container
+    # We prefer isolation of the container over isolation of tabs within Chrome,
+    # and thus disable the sandbox.
+    # See also:
     # https://github.com/SeleniumHQ/selenium/issues/15327#issuecomment-2689287561
     webdriver_options.add_argument("--no-sandbox")