chrome: check for binary in known locations

Author: thseiler

html2print/html2print.py

@@ -5,6 +5,7 @@
 import os.path
 import platform
 import re
+import shutil
 import subprocess
 import sys
 import zipfile
@@ -39,7 +40,8 @@
 
 
 class ChromeDriverManager:
-    def get_chrome_driver(self, path_to_cache_dir: str):
+    def get_chrome_driver(self, path_to_cache_dir: str) -> str:
+        """Return path to downloaded chromedriver."""
         chrome_version = self.get_chrome_version()
 
         # If Web Driver Manager cannot detect Chrome, it returns None.
@@ -102,15 +104,69 @@ def get_chrome_driver(self, path_to_cache_dir: str):
 
         return path_to_downloaded_chrome_driver
 
+    @staticmethod
+    def find_chrome() -> str:
+        """Find path to Chrome browser across Windows, macOS, and Linux."""
+
+        os_name = platform.system()
+        if os_name == "Windows":
+            # Check Windows standard locations for chrome and chromium
+            userprofile = os.environ.get("LOCALAPPDATA", r"C:\Users\Default\AppData\Local")
+            locations = [
+                os.path.join(os.environ.get("PROGRAMFILES", r"C:\Program Files"), "Google", "Chrome", "Application", "chrome.exe"),
+                os.path.join(os.environ.get("PROGRAMFILES(X86)", r"C:\Program Files (x86)"), "Google", "Chrome", "Application", "chrome.exe"),
+                os.path.join(os.environ.get("PROGRAMFILES", r"C:\Program Files"), "Chromium", "Application", "chrome.exe"),
+                os.path.join(os.environ.get("PROGRAMFILES(X86)", r"C:\Program Files (x86)"), "Chromium", "Application", "chrome.exe"),
+                os.path.join(userprofile, "Chromium","Application","chrome.exe"),
+                os.path.join(userprofile, "Chromium","Application","chromium.exe"),
+            ]
+        elif os_name == "Darwin":
+            # macOS standard locations
+            locations = [
+                "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome",
+                os.path.expanduser("~/Applications/Google Chrome.app/Contents/MacOS/Google Chrome")
+            ]
+        elif os_name == "Linux":
+            # Linux: check if chrome or chromium is in PATH
+            chrome_path = shutil.which("google-chrome") or shutil.which("chrome") or shutil.which("chromium") or shutil.which("chromium-browser")
+            if chrome_path:
+                return chrome_path
+            locations = [
+                "/usr/bin/google-chrome",
+                "/usr/local/bin/google-chrome",
+                "/usr/bin/chromium-browser",
+                "/snap/bin/chromium",
+            ]
+        else:
+            raise Exception(f"Unsupported platform: {sys.platform}")
+
+        for path in locations:
+            if path and os.path.exists(path):
+                return path
+
+        print("html2print: Chrome executable was not found in any usual location - falling back to webdriver's autodetection") # noqa: T201
+        return ""
+
     @staticmethod
     def _download_chromedriver(
         chrome_major_version,
         os_type: str,
         path_to_driver_cache_dir,
         path_to_cached_chrome_driver,
-    ):
+    ) -> str:
         url = "https://googlechromelabs.github.io/chrome-for-testing/known-good-versions-with-downloads.json"
-        response = ChromeDriverManager.send_http_get_request(url).json()
+        response = ChromeDriverManager.send_http_get_request(url)
+        if response is None:
+            raise RuntimeError(
+                "Could not download known-good-versions-with-downloads.json"
+            )
+
+        response = response.json()
+        if response is None:
+            raise RuntimeError(
+                "Could not parse known-good-versions-with-downloads.json"
+            )
+        assert isinstance(response, dict)
 
         matching_versions = [
             item
@@ -143,6 +199,11 @@ def _download_chromedriver(
         )
         response = ChromeDriverManager.send_http_get_request(driver_url)
 
+        if response is None:
+            raise Exception(
+                f"Could not download ChromeDriver from {driver_url}"
+            )
+
         Path(path_to_driver_cache_dir).mkdir(parents=True, exist_ok=True)
         zip_path = os.path.join(path_to_driver_cache_dir, "chromedriver.zip")
         print(  # noqa: T201
@@ -160,7 +221,7 @@ def _download_chromedriver(
         return path_to_cached_chrome_driver
 
     @staticmethod
-    def send_http_get_request(url, params=None, **kwargs) -> Response:
+    def send_http_get_request(url, params=None, **kwargs) -> Optional[Response]:
         last_error: Optional[Exception] = None
         for attempt in range(1, 4):
             print(  # noqa: T201
@@ -180,9 +241,10 @@ def send_http_get_request(url, params=None, **kwargs) -> Response:
             f"html2print: "
             f"failed to get response for URL: {url} with error: {last_error}"
         )
+        return None
 
     @staticmethod
-    def get_chrome_version():
+    def get_chrome_version() -> str:
         # Special case: GitHub Actions macOS CI machines have both
         # Google Chrome for Testing and normal Google Chrome installed, and
         # sometimes their versions are of different major version families.
@@ -312,21 +374,25 @@ def create_webdriver(
 ) -> webdriver.Chrome:
     print("html2print: creating ChromeDriver service.", flush=True)  # noqa: T201
     if chromedriver is None:
-        path_to_chrome = ChromeDriverManager().get_chrome_driver(
+        path_to_chromedriver = ChromeDriverManager().get_chrome_driver(
             path_to_cache_dir
         )
     else:
-        path_to_chrome = chromedriver
-    print(f"html2print: ChromeDriver available at path: {path_to_chrome}")  # noqa: T201
+        path_to_chromedriver = chromedriver
+    print(f"html2print: ChromeDriver available at path: {path_to_chromedriver}")  # noqa: T201
 
     if debug:
         service = Service(
-            path_to_chrome, log_output=PATH_TO_CHROME_DRIVER_DEBUG_LOG
+            path_to_chromedriver, log_output=PATH_TO_CHROME_DRIVER_DEBUG_LOG
         )
     else:
-        service = Service(path_to_chrome)
+        service = Service(path_to_chromedriver)
+
+    path_to_chrome = ChromeDriverManager.find_chrome()
+    print(f"html2print: Chrome available at path: {path_to_chrome}")  # noqa: T201
 
     webdriver_options = Options()
+    webdriver_options.binary_location = path_to_chrome
     webdriver_options.add_argument("start-maximized")
     webdriver_options.add_argument("disable-infobars")
     # Doesn't seem to be needed.