Skip to content

Commit ba9a320

Browse files
committed
Refactor enter key display text to strings.xml
1 parent 7f97842 commit ba9a320

2 files changed

Lines changed: 21 additions & 14 deletions

File tree

app/src/main/java/io/github/yawnoc/strokeinput/StrokeInputService.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -121,33 +121,26 @@ private void setEnterKeyDisplayText() {
121121
String enterKeyDisplayText = null;
122122
switch (inputOptionsBits & EditorInfo.IME_MASK_ACTION) {
123123
case EditorInfo.IME_ACTION_DONE:
124-
// U+2713 CHECK MARK
125-
enterKeyDisplayText = "✓";
124+
enterKeyDisplayText = getString(R.string.display_text__done);
126125
break;
127126
case EditorInfo.IME_ACTION_GO:
128-
// U+2B95 RIGHTWARDS BLACK ARROW
129-
enterKeyDisplayText = "⮕";
127+
enterKeyDisplayText = getString(R.string.display_text__go);
130128
break;
131129
case EditorInfo.IME_ACTION_NEXT:
132-
// U+2398 NEXT PAGE
133-
enterKeyDisplayText = "⎘";
130+
enterKeyDisplayText = getString(R.string.display_text__next);
134131
break;
135132
case EditorInfo.IME_ACTION_PREVIOUS:
136-
// U+2397 PREVIOUS PAGE
137-
enterKeyDisplayText = "⎗";
133+
enterKeyDisplayText = getString(R.string.display_text__previous);
138134
break;
139135
case EditorInfo.IME_ACTION_SEARCH:
140-
// U+1F50D LEFT-POINTING MAGNIFYING GLASS
141-
enterKeyDisplayText = "\uD83D\uDD0D";
136+
enterKeyDisplayText = getString(R.string.display_text__search);
142137
break;
143138
case EditorInfo.IME_ACTION_SEND:
144-
// U+27A4 BLACK RIGHTWARDS ARROWHEAD
145-
enterKeyDisplayText = "➤";
139+
enterKeyDisplayText = getString(R.string.display_text__send);
146140
break;
147141
}
148142
if (!enterKeyHasAction || enterKeyDisplayText == null) {
149-
// U+23CE RETURN SYMBOL
150-
enterKeyDisplayText = "⏎";
143+
enterKeyDisplayText = getString(R.string.display_text__return);
151144
}
152145

153146
for (final Keyboard keyboard : keyboardSet) {

app/src/main/res/values/strings.xml

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,18 @@
4444
<!-- Full stop: U+002E FULL STOP, U+3002 IDEOGRAPHIC FULL STOP -->
4545
<string name="value_text__qwerty_full_stop" translatable="false">.</string>
4646
<string name="value_text__strokes_full_stop" translatable="false">。</string>
47+
<!-- Enter key "done": U+2713 CHECK MARK -->
48+
<string name="display_text__done" translatable="false">✓</string>
49+
<!-- Enter key "go": U+2B95 RIGHTWARDS BLACK ARROW -->
50+
<string name="display_text__go" translatable="false">⮕</string>
51+
<!-- Enter key "next": U+2398 NEXT PAGE -->
52+
<string name="display_text__next" translatable="false">⎘</string>
53+
<!-- Enter key "previous": U+2397 PREVIOUS PAGE -->
54+
<string name="display_text__previous" translatable="false">⎗</string>
55+
<!-- Enter key "search": U+1F50D LEFT-POINTING MAGNIFYING GLASS -->
56+
<string name="display_text__search" translatable="false">🔍</string>
57+
<!-- Enter key "send": U+27A4 BLACK RIGHTWARDS ARROWHEAD -->
58+
<string name="display_text__send" translatable="false">➤</string>
59+
<!-- Enter key "return": U+23CE RETURN SYMBOL -->
60+
<string name="display_text__return" translatable="false">⏎</string>
4761
</resources>

0 commit comments

Comments
 (0)