Skip to content

Commit ec00bcc

Browse files
committed
Fix edge-to-edge behaviour for landscape WebView alerts
by side-stepping the broken landscape `fitsSystemWindows` (see a148480) by changing the alert to be floating rather than fullscreen. The non-fullscreen alert isn't particularly wide, but if you're viewing the About or Help in landscape, you deserve to be punished.
1 parent a148480 commit ec00bcc

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44
## [Unreleased]
55

66
- Upgraded Android SDK to Level 36
7+
- Changed Help/About pages to non-fullscreen to avoid edge-to-edge breakage
78
- Upgraded Android Gradle Plugin to 8.13.0
89
- Upgraded Material Components For Android to 1.13.0
910
- Upgraded androidx.test.ext:junit to 1.3.0

app/src/main/res/values/styles.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848
<item name="android:padding">@dimen/padding__dialog_button</item>
4949
</style>
5050
<style name="StrokeInputAlert" parent="Theme.StrokeInput">
51-
<item name="android:fitsSystemWindows">true</item>
51+
<item name="android:windowIsFloating">true</item>
5252
<item name="android:windowBackground">@color/very_dark_grey</item>
5353
<item name="android:backgroundDimEnabled">true</item>
5454
</style>

0 commit comments

Comments
 (0)