fix(presentation-editor): route tracked-change navigation through body editor

Author: luccas-harbour

packages/super-editor/src/editors/v1/core/presentation-editor/PresentationEditor.ts

@@ -5970,15 +5970,15 @@ export class PresentationEditor extends EventEmitter {
   }
 
   async #navigateToTrackedChange(id: string): Promise<boolean> {
-    const activeEditor = this.getActiveEditor();
-    const setCursorById = activeEditor?.commands?.setCursorById;
-    if (!activeEditor || typeof setCursorById !== 'function') return false;
+    const bodyEditor = this.#resolveBodyEditorForNavigation();
+    const setCursorById = bodyEditor?.commands?.setCursorById;
+    if (!bodyEditor || typeof setCursorById !== 'function') return false;
 
     if (setCursorById(id, { preferredActiveThreadId: id })) {
       return true;
     }
 
-    const resolved = resolveTrackedChange(activeEditor, id);
+    const resolved = resolveTrackedChange(bodyEditor, id);
     if (!resolved) return false;
 
     if (setCursorById(resolved.rawId, { preferredActiveThreadId: resolved.rawId })) {
@@ -5989,8 +5989,8 @@ export class PresentationEditor extends EventEmitter {
       behavior: 'auto',
       block: 'center',
     });
-    activeEditor.commands?.setTextSelection?.({ from: resolved.from, to: resolved.from });
-    activeEditor.view?.focus?.();
+    bodyEditor.commands?.setTextSelection?.({ from: resolved.from, to: resolved.from });
+    bodyEditor.view?.focus?.();
 
     return true;
   }

packages/super-editor/src/editors/v1/core/presentation-editor/tests/PresentationEditor.goToAnchor.test.ts

@@ -663,7 +663,8 @@ describe('PresentationEditor - goToAnchor', () => {
       documentId: 'test-doc',
     });
 
-    mockActiveEditor.commands.setCursorById = vi.fn().mockReturnValueOnce(false).mockReturnValueOnce(true);
+    const bodyEditor = editor.getActiveEditor();
+    bodyEditor.commands.setCursorById = vi.fn().mockReturnValueOnce(false).mockReturnValueOnce(true);
     editor.getActiveEditor = vi.fn(() => mockActiveEditor as never);
     mockResolveTrackedChange.mockReturnValueOnce({
       id: 'canonical-tc-id',
@@ -683,13 +684,14 @@ describe('PresentationEditor - goToAnchor', () => {
     });
 
     expect(result).toBe(true);
-    expect(mockActiveEditor.commands.setCursorById).toHaveBeenNthCalledWith(1, 'canonical-tc-id', {
+    expect(bodyEditor.commands.setCursorById).toHaveBeenNthCalledWith(1, 'canonical-tc-id', {
       preferredActiveThreadId: 'canonical-tc-id',
     });
-    expect(mockResolveTrackedChange).toHaveBeenCalledWith(mockActiveEditor, 'canonical-tc-id');
-    expect(mockActiveEditor.commands.setCursorById).toHaveBeenNthCalledWith(2, 'raw-tc-id', {
+    expect(mockResolveTrackedChange).toHaveBeenCalledWith(bodyEditor, 'canonical-tc-id');
+    expect(bodyEditor.commands.setCursorById).toHaveBeenNthCalledWith(2, 'raw-tc-id', {
       preferredActiveThreadId: 'raw-tc-id',
     });
+    expect(mockActiveEditor.commands.setCursorById).toBeUndefined();
   });
 
   it('falls back to scroll + setTextSelection when both setCursorById attempts fail for tracked changes', async () => {
@@ -698,7 +700,8 @@ describe('PresentationEditor - goToAnchor', () => {
       documentId: 'test-doc',
     });
 
-    mockActiveEditor.commands.setCursorById = vi.fn().mockReturnValue(false);
+    const bodyEditor = editor.getActiveEditor();
+    bodyEditor.commands.setCursorById = vi.fn().mockReturnValue(false);
     editor.getActiveEditor = vi.fn(() => mockActiveEditor as never);
     editor.scrollToPositionAsync = vi.fn().mockResolvedValue(undefined);
 
@@ -720,12 +723,13 @@ describe('PresentationEditor - goToAnchor', () => {
     });
 
     expect(result).toBe(true);
-    expect(mockActiveEditor.commands.setCursorById).toHaveBeenCalledTimes(2);
+    expect(bodyEditor.commands.setCursorById).toHaveBeenCalledTimes(2);
     expect(editor.scrollToPositionAsync).toHaveBeenCalledWith(88, {
       behavior: 'auto',
       block: 'center',
     });
-    expect(mockActiveEditor.commands.setTextSelection).toHaveBeenCalledWith({ from: 88, to: 88 });
-    expect(mockActiveEditor.view?.focus).toHaveBeenCalled();
+    expect(bodyEditor.commands.setTextSelection).toHaveBeenCalledWith({ from: 88, to: 88 });
+    expect(bodyEditor.view?.focus).toHaveBeenCalled();
+    expect(mockResolveTrackedChange).toHaveBeenCalledWith(bodyEditor, 'canonical-tc-id');
   });
 });