fix: address review comments

Author: VladaHarbour

packages/super-editor/src/editors/v1/extensions/linked-styles/helpers.js

@@ -380,16 +380,24 @@ export const applyLinkedStyleToTransaction = (tr, editor, style) => {
     };
   };
 
-  // Function to clear formatting marks from text content
-  const clearFormattingMarks = (startPos, endPos) => {
-    tr.doc.nodesBetween(startPos, endPos, (node, pos) => {
-      if (node.isText && node.marks.length > 0) {
-        node.marks.forEach((mark) => {
-          if (FORMATTING_MARK_NAMES.has(mark.type.name)) {
-            tr.removeMark(pos, pos + node.nodeSize, mark);
-          }
-        });
+  // Clear FORMATTING_MARK_NAMES only inside [rangeFrom, rangeTo), not across whole text nodes
+  // (selection can split mid-node; removeMark must use the intersection with each text slice).
+  const clearFormattingMarks = (rangeFrom, rangeTo) => {
+    tr.doc.nodesBetween(rangeFrom, rangeTo, (node, pos) => {
+      if (!node.isText || node.marks.length === 0) {
+        return true;
       }
+      const nodeEnd = pos + node.nodeSize;
+      const clearFrom = Math.max(pos, rangeFrom);
+      const clearTo = Math.min(nodeEnd, rangeTo);
+      if (clearFrom >= clearTo) {
+        return true;
+      }
+      node.marks.forEach((mark) => {
+        if (FORMATTING_MARK_NAMES.has(mark.type.name)) {
+          tr.removeMark(clearFrom, clearTo, mark);
+        }
+      });
       return true;
     });
   };
@@ -447,7 +455,8 @@ export const applyLinkedStyleToTransaction = (tr, editor, style) => {
       if (startPara && endPara && startPara.pos === endPara.pos) {
         const bounds = getParagraphTextBounds(tr.doc, startPara.pos, startPara.node);
         const coversFullParagraphText = bounds && from <= bounds.from && to >= bounds.to;
-        if (!coversFullParagraphText) {
+        // No text (empty / image-only): cannot do linked character range apply; use paragraph path below.
+        if (bounds && !coversFullParagraphText) {
           clearFormattingMarks(from, to);
           applyCharacterStyleMarkToRange(tr, textStyleType, from, to, linkedCharStyleId);
           clearStoredFormattingMarks();
@@ -467,6 +476,18 @@ export const applyLinkedStyleToTransaction = (tr, editor, style) => {
     return true;
   });
 
+  // nodesBetween often skips block parents when the range only covers inline content (e.g. image-only).
+  if (paragraphPositions.length === 0 && from !== to) {
+    const seen = new Set();
+    const pushParagraph = (info) => {
+      if (!info || seen.has(info.pos)) return;
+      seen.add(info.pos);
+      paragraphPositions.push({ node: info.node, pos: info.pos });
+    };
+    pushParagraph(findParentNodeClosestToPos(tr.doc.resolve(from), (n) => n.type.name === 'paragraph'));
+    pushParagraph(findParentNodeClosestToPos(tr.doc.resolve(to), (n) => n.type.name === 'paragraph'));
+  }
+
   // Apply style to all paragraphs in selection (with clean attributes and cleared marks)
   paragraphPositions.forEach(({ node, pos }) => {
     // Clear formatting marks within this paragraph

packages/super-editor/src/editors/v1/extensions/linked-styles/linked-styles.test.js

@@ -1,5 +1,5 @@
 import { beforeAll, beforeEach, describe, expect, it, vi } from 'vitest';
-import { NodeSelection, TextSelection } from 'prosemirror-state';
+import { EditorState, NodeSelection, TextSelection } from 'prosemirror-state';
 import { initTestEditor, loadTestDataForEditorTests } from '../../tests/helpers/helpers.js';
 
 const findParagraphInfo = (doc, paragraphIndex) => {
@@ -178,6 +178,93 @@ describe('LinkedStyles Extension', () => {
         });
         expect(sawEmphasisInSelection).toBe(true);
       });
+
+      it('partial linked character apply clears formatting only inside the selection', () => {
+        const minimalDoc = editor.schema.nodeFromJSON({
+          type: 'doc',
+          content: [
+            {
+              type: 'paragraph',
+              content: [
+                {
+                  type: 'run',
+                  content: [{ type: 'text', text: 'Hello world' }],
+                },
+              ],
+            },
+          ],
+        });
+        editor.setState(EditorState.create({ schema: editor.schema, doc: minimalDoc }));
+
+        let lineFrom;
+        let lineTo;
+        editor.state.doc.descendants((node, pos) => {
+          if (node.isText && node.text === 'Hello world') {
+            lineFrom = pos;
+            lineTo = pos + node.nodeSize;
+            return false;
+          }
+          return true;
+        });
+        expect(lineFrom).toBeDefined();
+
+        const { bold } = editor.schema.marks;
+        editor.view.dispatch(editor.view.state.tr.addMark(lineFrom, lineTo, bold.create()));
+
+        const world = 'world';
+        const selFrom = lineFrom + 'Hello world'.indexOf(world);
+        const selTo = selFrom + world.length;
+
+        const styleWithLink = {
+          ...headingStyle,
+          type: 'paragraph',
+          definition: {
+            ...headingStyle.definition,
+            attrs: { ...headingStyle.definition.attrs, link: 'Emphasis' },
+          },
+        };
+        editor.view.dispatch(
+          editor.view.state.tr.setSelection(TextSelection.create(editor.view.state.doc, selFrom, selTo)),
+        );
+        expect(editor.commands.setLinkedStyle(styleWithLink)).toBe(true);
+
+        const insidePrefix = selFrom - 1;
+        expect(insidePrefix).toBeGreaterThanOrEqual(lineFrom);
+        expect(
+          editor.state.doc
+            .resolve(insidePrefix)
+            .marks()
+            .some((m) => m.type.name === 'bold'),
+        ).toBe(true);
+      });
+
+      it('applies paragraph style when the paragraph has no text (e.g. break-only)', () => {
+        const minimalDoc = editor.schema.nodeFromJSON({
+          type: 'doc',
+          content: [
+            {
+              type: 'paragraph',
+              content: [
+                {
+                  type: 'run',
+                  content: [{ type: 'hardBreak', attrs: {} }],
+                },
+              ],
+            },
+          ],
+        });
+        editor.setState(EditorState.create({ schema: editor.schema, doc: minimalDoc }));
+
+        const info = findParagraphInfo(editor.state.doc, 0);
+        expect(info).toBeTruthy();
+        const innerFrom = info.pos + 1;
+        const innerTo = info.pos + info.node.nodeSize - 1;
+        editor.view.dispatch(editor.state.tr.setSelection(TextSelection.create(editor.state.doc, innerFrom, innerTo)));
+
+        expect(editor.commands.setLinkedStyle(headingStyle)).toBe(true);
+        const para = findParagraphInfo(editor.state.doc, 0);
+        expect(getParagraphProps(para.node).styleId).toBe('Heading1');
+      });
     });
 
     describe('toggleLinkedStyle', () => {