fix(bookmarks): allocate bookmark IDs across all stories to prevent cross-story collisions

allocateBookmarkId only scanned the story-local doc, so inserting a
bookmark in a header could reuse an ID already present in the body.
Reuse findAllBookmarksInDocument to scan all stories, matching the
scope of the existing name-uniqueness check.

Author: luccas-harbour

packages/super-editor/src/editors/v1/document-api-adapters/plan-engine/bookmark-wrappers.test.ts

@@ -133,6 +133,13 @@ describe('bookmarksInsertWrapper', () => {
       { type: { name: 'bookmarkEnd' }, attrs: { id: '9' } },
       { type: { name: 'bookmarkStart' }, attrs: { id: 'not-a-number' } },
     ]);
+    const existingEntries = [
+      { name: 'a', bookmarkId: '2', storyKey: 'body' },
+      { name: 'b', bookmarkId: '9', storyKey: 'body' },
+      { name: 'c', bookmarkId: 'not-a-number', storyKey: 'body' },
+    ];
+    // Called twice: once for bookmarkExistsAnywhere, once for allocateBookmarkId.
+    vi.mocked(findAllBookmarksInDocument).mockReturnValueOnce(existingEntries).mockReturnValueOnce(existingEntries);
 
     const result = bookmarksInsertWrapper(editor, makeInput());
 

packages/super-editor/src/editors/v1/document-api-adapters/plan-engine/bookmark-wrappers.ts

@@ -57,14 +57,12 @@ function parseBookmarkId(raw: unknown): number | null {
   return Number.isInteger(parsed) && parsed >= 0 ? parsed : null;
 }
 
-function allocateBookmarkId(doc: import('prosemirror-model').Node): string {
+function allocateBookmarkId(editor: Editor): string {
   let maxId = -1;
-  doc.descendants((node) => {
-    if (node.type.name !== 'bookmarkStart' && node.type.name !== 'bookmarkEnd') return true;
-    const id = parseBookmarkId(node.attrs?.id);
+  for (const entry of findAllBookmarksInDocument(editor)) {
+    const id = parseBookmarkId(entry.bookmarkId);
     if (id !== null && id > maxId) maxId = id;
-    return true;
-  });
+  }
   return String(maxId + 1);
 }
 
@@ -142,7 +140,7 @@ export function bookmarksInsertWrapper(
     const receipt = executeDomainCommand(
       storyEditor,
       () => {
-        const bookmarkId = allocateBookmarkId(storyEditor.state.doc);
+        const bookmarkId = allocateBookmarkId(editor);
         const startAttrs: Record<string, unknown> = {
           name: input.name,
           id: bookmarkId,