Merge pull request #10 from sweatco/fix/cli-arg-types

fix: fix cli args

Author: Augustach

src/bundle/assetCodepushDiffPlugin.ts

@@ -9,13 +9,13 @@ interface DiffAssetData extends AssetData {
   mainBundleAssets?: MainAssets
 }
 
-let hashes: Hashes = {}
-const CHANGED_ASSETS_PATH: string | undefined = process.env.CHANGED_ASSETS_PATH
+let baseHashes: Hashes = {}
+const BASE_ASSETS_PATH: string | undefined = process.env.BASE_ASSETS_PATH
 const PLATFORM: string | undefined = process.env.CODE_PUSH_PLATFORM
 
-if (CHANGED_ASSETS_PATH) {
-  const json = fs.readFileSync(CHANGED_ASSETS_PATH, 'utf-8')
-  hashes = JSON.parse(json)
+if (BASE_ASSETS_PATH) {
+  const json = fs.readFileSync(BASE_ASSETS_PATH, 'utf-8')
+  baseHashes = JSON.parse(json)
 }
 
 export async function assetCodepushDiffPlugin(assetData: DiffAssetData) {
@@ -30,7 +30,7 @@ export async function assetCodepushDiffPlugin(assetData: DiffAssetData) {
     const scale = scales[i]
     if (file != null && scale != null) {
       const hash = await fileHash(file)
-      const baselineFile = hashes[hash]
+      const baselineFile = baseHashes[hash]
       if (baselineFile) {
         assets[scale] = mainAssetPath(baselineFile)
       }

src/bundle/bundle.ts

@@ -48,6 +48,7 @@ const bundleReactNative = async (config: BundlerConfig, shouldBuildSourceMaps?:
     extraHermesFlags = [],
     useHermes = true,
     outputDir,
+    development,
   } = config
   rmRf(outputDir)
   mkdir(outputDir)
@@ -59,7 +60,7 @@ const bundleReactNative = async (config: BundlerConfig, shouldBuildSourceMaps?:
   metroBundle({
     bundleCommand,
     bundleName,
-    development: false,
+    development,
     entryFile,
     outputDir,
     platform: os,
@@ -87,14 +88,14 @@ const checkoutAndBuild = async (bundlerConfig: BundlerConfig, commit: string) =>
 }
 
 const readBaseHashes = async (bundlerConfig: BundlerConfig, base: string): Promise<Hashes> => {
-  if (!process.env.CHANGED_ASSETS_PATH) {
+  if (!process.env.BASE_ASSETS_PATH) {
     info(`Bundling for ${base}`)
     const baseOutput = await checkoutAndBuild(bundlerConfig, base)
     const baseHashes = await hashes(baseOutput.outputDir)
-    const changedAssetsPath = path.join(tmpdir(), 'changed-assets.json')
-    fs.writeFileSync(changedAssetsPath, JSON.stringify(baseHashes))
-    process.env.CHANGED_ASSETS_PATH = changedAssetsPath
+    const baseAssetsPath = path.join(tmpdir(), 'base-assets.json')
+    fs.writeFileSync(baseAssetsPath, JSON.stringify(baseHashes))
+    process.env.BASE_ASSETS_PATH = baseAssetsPath
   }
 
-  return JSON.parse(fs.readFileSync(process.env.CHANGED_ASSETS_PATH, 'utf8'))
+  return JSON.parse(fs.readFileSync(process.env.BASE_ASSETS_PATH, 'utf8'))
 }

src/bundle/types.ts

@@ -23,6 +23,7 @@ export interface BundlerConfig {
   useHermes?: boolean
   extraHermesFlags?: string[]
   bundleCommand?: string
+  development?: boolean
 }
 
 type Config = Partial<BundlerConfig> & VersionSearchParams

src/cli/appcenterArgs.ts

@@ -1,4 +1,4 @@
-import type { Argv } from 'yargs'
+import { type Argv } from 'yargs'
 
 export const appcenterArgs = <T = {}>(yargs: Argv<T>) =>
   yargs
@@ -16,7 +16,7 @@ export const appcenterArgs = <T = {}>(yargs: Argv<T>) =>
       alias: 'b',
       type: 'string',
     })
-    .option('development', { type: 'string' })
+    .option('development', { type: 'boolean', default: false })
     .option('entry-file', { alias: 'e', type: 'string' })
     .option('gradle-file', { alias: 'g', type: 'string' })
     .option('pod-file', { type: 'string' })
@@ -30,5 +30,5 @@ export const appcenterArgs = <T = {}>(yargs: Argv<T>) =>
     .option('output-dir', { alias: ['o', 'output-path'], type: 'string' })
     .option('extra-bundler-option', { alias: ['extra-bundler-options'], default: [], type: 'array' })
     .option('extra-hermes-flag', { alias: ['extra-hermes-flags'], type: 'array', default: [] })
-    .option('use-hermes', { default: true })
+    .option('use-hermes', { default: true, type: 'boolean' })
     .option('disable-duplicate-release-error', { type: 'boolean', default: true })