fix: add reinstallNodeModulesCommand arg to cli options

Author: Augustach

src/bundle/bundle.ts

@@ -54,7 +54,7 @@ const bundleReactNative = async (config: BundlerConfig, shouldBuildSourceMaps?:
   mkdir(outputDir)
   mkdir(path.dirname(sourcemapOutput))
 
-  info(`Using ${config.reinstallNodeModulesCommand} to install node modules`)
+  info(`Using '${config.reinstallNodeModulesCommand}' to install node modules`)
   await execCommand(config.reinstallNodeModulesCommand)
 
   await runReactNativeBundleCommand(

src/bundle/utils.ts

@@ -88,9 +88,9 @@ export function buildBundleConfig(args: CommandArgs): BundlerConfig {
     outputDir: Path.join(tmpdir(), 'codepush-diff'),
     sourcemapOutputDir: Path.join(tmpdir(), args.sourcemapOutput ?? 'codepush-diff-sourcemap'),
     bundleName: os === 'ios' ? 'main.jsbundle' : `index.${os}.bundle`,
-    reinstallNodeModulesCommand: installNodeModulesCommand(),
     ...args,
     os,
     entryFile: args.entryFile ?? defaultEntryFile(os),
+    reinstallNodeModulesCommand: args.reinstallNodeModulesCommand ?? installNodeModulesCommand(),
   }
 }

src/cli/appcenterArgs.ts

@@ -1,6 +1,6 @@
 import type { Argv } from 'yargs'
 
-export const appcenterArgs = (yargs: Argv<{}>) =>
+export const appcenterArgs = <T = {}>(yargs: Argv<T>) =>
   yargs
     .option('deployment-name', { alias: 'd', default: 'Staging', type: 'string' })
     .option('description', { type: 'string' })

src/cli/bundleArgs.ts

@@ -0,0 +1,7 @@
+import type { Argv } from 'yargs'
+
+export const bundleArgs = <T = {}>(yargs: Argv<T>) =>
+  yargs
+    .option('base', { type: 'string', demandOption: true })
+    .option('reinstallNodeModulesCommand', { type: 'string', alias: ['npm'] })
+    .option('rest', { type: 'string', default: '' })

src/cli/index.ts

@@ -6,28 +6,18 @@ import { appcenterArgs } from './appcenterArgs'
 import { buildBundleConfig, getAppVersion, info } from '../bundle/utils'
 import { bundle } from '../bundle/bundle'
 import { execSync } from 'child_process'
+import { bundleArgs } from './bundleArgs'
 
 yargs(hideBin(process.argv))
-  .command(
-    'target <app>',
-    'Get the version of the app that will be uploaded to AppCenter.',
-    (yargs) =>
-      appcenterArgs(yargs).positional('app', { type: 'string', demandOption: true, alias: ['platform', 'os'] }),
-    async (args) => {
-      console.log(args)
-      const bundlerConfig = buildBundleConfig(args)
-      const version = await getAppVersion(bundlerConfig)
-
-      console.log(version)
-    }
-  )
   .command(
     'bundle <app>',
     'Bundle the app for release.',
     (yargs) =>
-      appcenterArgs(yargs)
-        .positional('app', { type: 'string', demandOption: true, alias: ['platform', 'os'] })
-        .option('base', { type: 'string', demandOption: true }),
+      bundleArgs(appcenterArgs(yargs)).positional('app', {
+        type: 'string',
+        demandOption: true,
+        alias: ['platform', 'os'],
+      }),
     async (args) => {
       const result = await bundle({ ...args })
       console.log(result)
@@ -36,11 +26,7 @@ yargs(hideBin(process.argv))
   .command(
     'release-react',
     'Build and release a React Native app to AppCenter.',
-    (yargs) =>
-      appcenterArgs(yargs)
-        .option('app', { type: 'string', demandOption: true, alias: ['a'] })
-        .option('base', { type: 'string', demandOption: true })
-        .option('rest', { type: 'string', default: '' }),
+    (yargs) => bundleArgs(appcenterArgs(yargs)).option('app', { type: 'string', demandOption: true, alias: ['a'] }),
     async (args) => {
       const bundlerConfig = buildBundleConfig({ ...args })
       const version = args.version ?? (await getAppVersion(bundlerConfig))