chore: review

Author: ovitrif

app/src/main/java/to/bitkit/services/LightningService.kt

@@ -195,22 +195,17 @@ class LightningService @Inject constructor(
                 }
             }
 
-            buildNode().recoverCatching {
-                if (it !is BuildException.DangerousValue) throw it
-                // Handle `DangerousValue` with recovery flow
+            buildNode().recoverCatching { error ->
+                if (error !is BuildException.DangerousValue) throw error
                 Logger.warn(
-                    "Build failed with DangerousValue. Retrying with `accept_stale_channel_monitors` for recovery.",
-                    it,
+                    "Retrying build failed with 'DangerousValue' using 'setAcceptStaleChannelMonitors' for recovery.",
+                    error,
                     context = TAG,
                 )
                 builder.setAcceptStaleChannelMonitors(true)
                 buildNode()
-                    .onFailure { recoveryError ->
-                        Logger.error(
-                            "Error in recovery attempt with `accept_stale_channel_monitors`.",
-                            recoveryError,
-                            context = TAG,
-                        )
+                    .onFailure {
+                        Logger.error("Failed recovery retry using 'setAcceptStaleChannelMonitors'.", it, context = TAG)
                     }
                     .getOrThrow()
             }.getOrThrow()
@@ -249,7 +244,7 @@ class LightningService @Inject constructor(
                     lightningWalletSyncIntervalSecs = Env.walletSyncIntervalSecs,
                     feeRateCacheUpdateIntervalSecs = Env.walletSyncIntervalSecs,
                 ),
-                connectionTimeoutSecs = Env.walletSyncTimeoutSecs, // 10s
+                connectionTimeoutSecs = Env.walletSyncTimeoutSecs,
             ),
         )
     }

app/src/main/java/to/bitkit/utils/Errors.kt

@@ -49,6 +49,7 @@ class LdkError(private val inner: LdkException) : AppError("Unknown LDK error.")
                 is BuildException.InvalidAnnouncementAddresses -> "Invalid announcement addresses"
                 is BuildException.InvalidNodeAlias -> "Invalid node alias"
                 is BuildException.NetworkMismatch -> "Network mismatch"
+                is BuildException.DangerousValue -> "Dangerous value"
                 else -> exception.message
             }?.let { "LDK Build error: $it" }
         }