fix: stabilize mainnet LN payment nightly tests (#130)

Addresses flaky LN payment tests (Strike/WOS) that were failing ~50%
of nightly runs due to timing and network issues on CI runners.

Changes to ln.e2e.ts:
- Replace fixed sleep(15s) with explicit wallet readiness check
- Add explicit waits between screen transitions (amount, confirm)
- Increase payment timeout from 60s to 300s for mainnet routing
- Add error toast detection (PaymentFailed, ExpiredLightning, etc.)
- Add diagnostic logging at each step for CI failure diagnosis
- Use 60s address resolution timeout for LNURL endpoints

Changes to actions.ts:
- Increase TOS Continue button timeout to 60s for slow CI emulators
- Increase RestoreButton timeout to 60s
- Dismiss Android keyboard after seed entry to prevent UI blocking
- Replace Suggestions widget check with TotalBalance-primary
- Add configurable timeout to typeAddressAndVerifyContinue
- Add configurable addressTimeout to enterAddress

Made-with: Cursor

Author: piotr-iohk

test/helpers/actions.ts

@@ -671,7 +671,7 @@ export async function restoreWallet(
   }
 
   // Terms of service
-  await elementById('Continue').waitForDisplayed();
+  await elementById('Continue').waitForDisplayed({ timeout: 60_000 });
   await sleep(1000); // Wait for the app to settle
   await tap('Continue');
   await sleep(500);
@@ -688,6 +688,16 @@ export async function restoreWallet(
     await typeText('Word-0', seed);
   }
   await sleep(1500); // wait for the app to settle
+
+  if (driver.isAndroid) {
+    try {
+      await driver.hideKeyboard();
+    } catch {
+      // keyboard may already be hidden
+    }
+    await sleep(500);
+  }
+
   // Passphrase
   if (passphrase) {
     await tap('AdvancedButton');
@@ -696,7 +706,10 @@ export async function restoreWallet(
   }
 
   // Restore wallet
-  await tap('RestoreButton');
+  const restoreBtn = await elementById('RestoreButton');
+  await restoreBtn.waitForDisplayed({ timeout: 60_000 });
+  await sleep(150);
+  await restoreBtn.click();
   await waitForSetupWalletScreenFinish();
 
   // Wait for Get Started
@@ -729,9 +742,7 @@ export async function restoreWallet(
     }
   }
 
-  // Wait for Suggestions Label to appear
-  const suggestions = await elementById('Suggestions');
-  await suggestions.waitForDisplayed();
+  await elementById('TotalBalance-primary').waitForDisplayed({ timeout: 90_000 });
 }
 
 type addressType = 'bitcoin' | 'lightning';
@@ -1352,23 +1363,28 @@ export async function typeRecipientInput(
 export async function typeAddressAndVerifyContinue({
   address,
   reverse = false,
+  timeout = 30_000,
 }: {
   address: string;
   reverse?: boolean;
+  timeout?: number;
 }) {
   await typeRecipientInput(address);
   await sleep(1000);
-  await elementById('AddressContinue').waitForEnabled({ reverse });
+  await elementById('AddressContinue').waitForEnabled({ reverse, timeout });
 }
 
-export async function enterAddress(address: string, { acceptCameraPermission = true } = {}) {
+export async function enterAddress(
+  address: string,
+  { acceptCameraPermission = true, addressTimeout = 30_000 } = {},
+) {
   await tap('Send');
   await sleep(700);
   if (acceptCameraPermission) {
     await handleAndroidAlert('permission_allow_one_time_button');
   }
   await tap('RecipientManual');
-  await typeAddressAndVerifyContinue({ address });
+  await typeAddressAndVerifyContinue({ address, timeout: addressTimeout });
   await tap('AddressContinue');
 }
 

test/specs/mainnet/ln.e2e.ts

@@ -9,6 +9,13 @@ import {
 } from '../../helpers/actions';
 import { ciIt } from '../../helpers/suite';
 
+const PAYMENT_TIMEOUT_MS = 300_000;
+const WALLET_SYNC_TIMEOUT_MS = 90_000;
+const SCREEN_TRANSITION_TIMEOUT_MS = 60_000;
+const LN_STABILIZE_DELAY_MS = 10_000;
+
+const ERROR_TOASTS = ['PaymentFailedToast', 'ExpiredLightningToast', 'InsufficientSpendingToast'];
+
 type MainnetLnSuiteConfig = {
   suiteTag: string;
   testTag: string;
@@ -52,22 +59,76 @@ function resolveMainnetLnReceiver(config: MainnetLnSuiteConfig): MainnetLnReceiv
   };
 }
 
+async function waitForWalletReady(): Promise<void> {
+  console.info('→ [LN] Waiting for wallet home screen...');
+  await elementById('TotalBalance-primary').waitForDisplayed({ timeout: WALLET_SYNC_TIMEOUT_MS });
+  console.info('→ [LN] Home screen ready, letting LN node stabilize...');
+  await sleep(LN_STABILIZE_DELAY_MS);
+}
+
+async function waitForAmountScreen(): Promise<void> {
+  console.info('→ [LN] Waiting for amount entry screen...');
+  await elementById('N0').waitForDisplayed({ timeout: SCREEN_TRANSITION_TIMEOUT_MS });
+}
+
+async function waitForConfirmScreen(): Promise<void> {
+  console.info('→ [LN] Waiting for send confirmation screen...');
+  await elementById('GRAB').waitForDisplayed({ timeout: SCREEN_TRANSITION_TIMEOUT_MS });
+  await sleep(500);
+}
+
+async function waitForPaymentResult(): Promise<void> {
+  console.info(`→ [LN] Waiting for payment result (timeout: ${PAYMENT_TIMEOUT_MS / 1000}s)...`);
+  await browser.waitUntil(
+    async () => {
+      const success = await elementById('SendSuccess').isDisplayed().catch(() => false);
+      if (success) {
+        console.info('→ [LN] Payment succeeded');
+        return true;
+      }
+
+      for (const toastId of ERROR_TOASTS) {
+        const visible = await elementById(toastId).isDisplayed().catch(() => false);
+        if (visible) {
+          throw new Error(`Payment failed with error toast: ${toastId}`);
+        }
+      }
+
+      return false;
+    },
+    {
+      timeout: PAYMENT_TIMEOUT_MS,
+      interval: 3_000,
+      timeoutMsg: `Payment did not complete within ${PAYMENT_TIMEOUT_MS / 1000}s`,
+    },
+  );
+}
+
 async function sendPaymentToLnAddress(receiver: MainnetLnReceiver): Promise<void> {
+  console.info('→ [LN] Restoring wallet...');
   await restoreWallet(receiver.seed, {
     expectBackupSheet: false,
     reinstall: false,
     expectAndroidAlert: false,
   });
 
-  await sleep(15_000); // wait for wallet to stabilize
+  await waitForWalletReady();
 
-  await enterAddress(receiver.lnAddress, { acceptCameraPermission: false });
-  await enterAmount(receiver.amountSats);
+  console.info(`→ [LN] Entering address: ${receiver.lnAddress}`);
+  await enterAddress(receiver.lnAddress, { acceptCameraPermission: false, addressTimeout: 60_000 });
+  await waitForAmountScreen();
 
+  console.info(`→ [LN] Entering amount: ${receiver.amountSats} sats`);
+  await enterAmount(receiver.amountSats);
   await tap('ContinueAmount');
+
+  await waitForConfirmScreen();
+  console.info('→ [LN] Swiping to send...');
   await dragOnElement('GRAB', 'right', 0.95);
-  await elementById('SendSuccess').waitForDisplayed({ timeout: 60_000 });
+
+  await waitForPaymentResult();
   await tap('Close');
+  console.info('→ [LN] Test complete');
 }
 
 function defineMainnetLnSuite(config: MainnetLnSuiteConfig): void {