Merge pull request #43 from synonymdev/feat/kotlin-serialization-update

fix: kotlin serialization version and jvm bindings

Author: ovitrif

AGENTS.md

@@ -194,10 +194,13 @@ If anything is missing or cannot be verified, you must fix it before declaring s
 - NEVER suggest manually adding @Serializable annotations to generated Kotlin bindings
 - ALWAYS run `cargo fmt` before committing to ensure consistent code formatting
 - ALWAYS move imports to the top of the file when applicable (no inline imports in functions)
-- To regenerate ALL bindings (Swift, Kotlin, Python), use this command:
-  ```bash
-  RUSTFLAGS="--cfg no_download" cargo build && ./scripts/uniffi_bindgen_generate.sh && ./scripts/swift_create_xcframework_archive.sh && sh scripts/uniffi_bindgen_generate_kotlin_android.sh
-  ```
+- NEVER run binding generation scripts yourself - always ask the user to run them (they are long-running and resource-intensive)
+
+## Bindings Generation Command
+To regenerate ALL bindings (Swift, Kotlin, Python), use this command:
+```sh
+RUSTFLAGS="--cfg no_download" cargo build && ./scripts/uniffi_bindgen_generate.sh && ./scripts/swift_create_xcframework_archive.sh && sh scripts/uniffi_bindgen_generate_kotlin.sh && sh scripts/uniffi_bindgen_generate_kotlin_android.sh
+```
 
 ## Version Bumping Checklist
 When bumping the version, ALWAYS update ALL of these files:

CHANGELOG.md

@@ -1,10 +1,11 @@
-# 0.7.0-rc.16 (Synonym Fork)
+# 0.7.0-rc.17 (Synonym Fork)
 
 ## Bug Fixes
 - Fixed duplicate payment events (`PaymentReceived`, `PaymentSuccessful`, `PaymentFailed`) being
   emitted when LDK replays events after node restart.
 
 ## Synonym Fork Additions
+- Upgraded to Kotlin 2.2.0 for compatibility with consuming apps using Kotlin 2.x
 - Added JitPack support for `ldk-node-jvm` module to enable unit testing in consuming apps
 - Added runtime-adjustable wallet sync intervals for battery optimization on mobile:
   - `RuntimeSyncIntervals` struct with configurable `onchain_wallet_sync_interval_secs`,
@@ -504,4 +505,3 @@ integrated LDK and BDK-based wallets.
 
 **Note:** This release is still considered experimental, should not be run in
 production, and no compatibility guarantees are given until the release of 0.1.
-

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "ldk-node"
-version = "0.7.0-rc.16"
+version = "0.7.0-rc.17"
 authors = ["Elias Rohrer <dev@tnull.de>"]
 homepage = "https://lightningdevkit.org/"
 license = "MIT OR Apache-2.0"

Package.swift

@@ -3,8 +3,8 @@
 
 import PackageDescription
 
-let tag = "v0.7.0-rc.16"
-let checksum = "5ca612e30639e86d4a215c7819d93e55aba3c9a9ea704a79ab18d6df78c38b32"
+let tag = "v0.7.0-rc.17"
+let checksum = "b90aefa8285b7c4b459e107b611840e5f218689797c0dc24e8bb5e8d1208fa56"
 let url = "https://github.com/synonymdev/ldk-node/releases/download/\(tag)/LDKNodeFFI.xcframework.zip"
 
 let package = Package(

bindings/README.md

@@ -3,7 +3,7 @@
 ## Build All Bindings
 Run in the root dir:
 ```sh
-RUSTFLAGS="--cfg no_download" cargo build && ./scripts/uniffi_bindgen_generate.sh && ./scripts/swift_create_xcframework_archive.sh && sh scripts/uniffi_bindgen_generate_kotlin_android.sh
+RUSTFLAGS="--cfg no_download" cargo build && ./scripts/uniffi_bindgen_generate.sh && ./scripts/swift_create_xcframework_archive.sh && sh scripts/uniffi_bindgen_generate_kotlin.sh && sh scripts/uniffi_bindgen_generate_kotlin_android.sh
 ```
 
 ---

bindings/kotlin/ldk-node-android/build.gradle.kts

@@ -9,8 +9,8 @@ buildscript {
 }
 
 plugins {
-    kotlin("android") version "1.9.20" apply false
-    kotlin("plugin.serialization") version "1.9.20" apply false
+    kotlin("android") version "2.2.0" apply false
+    kotlin("plugin.serialization") version "2.2.0" apply false
 }
 
 // library version is defined in gradle.properties

bindings/kotlin/ldk-node-android/gradle.properties

@@ -2,4 +2,4 @@ org.gradle.jvmargs=-Xmx1536m
 android.useAndroidX=true
 android.enableJetifier=true
 kotlin.code.style=official
-libraryVersion=0.7.0-rc.16
+libraryVersion=0.7.0-rc.17

bindings/kotlin/ldk-node-android/lib/build.gradle.kts

@@ -53,11 +53,11 @@ android {
 dependencies {
     implementation("net.java.dev.jna:jna:5.12.0@aar")
     implementation("org.jetbrains.kotlin:kotlin-stdlib-jdk7")
-    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.6.4")
+    implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2")
     implementation("androidx.appcompat:appcompat:1.4.0")
     implementation("androidx.core:core-ktx:1.7.0")
-    implementation("org.jetbrains.kotlinx:atomicfu:0.23.1")
-    implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.6.0")
+    implementation("org.jetbrains.kotlinx:atomicfu:0.27.0")
+    implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.9.0")
     api("org.slf4j:slf4j-api:1.7.30")
 }