feat: android listing nodes and querying list of nodes in graph

fix: linting

Author: Jasonvdb

example/App.tsx

@@ -424,8 +424,7 @@ const App = (): ReactElement => {
 								return setMessage(decode.error.message);
 							}
 
-							const { recover_payee_pub_key, amount_satoshis, description } =
-								decode.value;
+							const { amount_satoshis, description } = decode.value;
 
 							const ownAmountSats = 1000;
 							Alert.alert(
@@ -467,7 +466,7 @@ const App = (): ReactElement => {
 								return setMessage(nodesRes.error.message);
 							}
 
-							let msg = 'Nodes: \n';
+							let msg = `Nodes (${nodesRes.value.length}): \n`;
 
 							const nodes = await ldk.networkGraphNodes(nodesRes.value);
 							if (nodes.isOk()) {
@@ -478,7 +477,7 @@ const App = (): ReactElement => {
 										lowest_inbound_channel_fees_base_sat,
 										announcement_info_last_update,
 									} = node;
-									let time = new Date(announcement_info_last_update);
+									const time = new Date(announcement_info_last_update);
 
 									msg += `\n\n${id}\nChannels: ${shortChannelIds.length}\n`;
 									msg += `Lowest inbound fee: ${lowest_inbound_channel_fees_base_sat} sat\n`;

lib/android/src/main/java/com/reactnativeldk/Helpers.kt

@@ -146,8 +146,10 @@ val NodeInfo.asJson: WritableMap
 
         val shortChannelIds = Arguments.createArray()
         _channels.iterator().forEach { shortChannelIds.pushString(it.toString()) }
-        result.putArray("channels", shortChannelIds)
-
+        result.putArray("shortChannelIds", shortChannelIds)
+        result.putInt("lowest_inbound_channel_fees_base_sat", (_lowest_inbound_channel_fees?._base_msat ?: 0) / 1000)
+        result.putInt("lowest_inbound_channel_fees_proportional_millionths", _lowest_inbound_channel_fees?._proportional_millionths ?: 0)
+        result.putDouble("announcement_info_last_update", (_announcement_info?._last_update ?: 0).toDouble() * 1000)
         return result
     }
 

lib/android/src/main/java/com/reactnativeldk/LdkModule.kt

@@ -820,9 +820,20 @@ class LdkModule(reactContext: ReactApplicationContext) : ReactContextBaseJavaMod
     fun networkGraphNodes(nodeIds: ReadableArray, promise: Promise) {
         val graph = networkGraph?.read_only() ?: return handleReject(promise, LdkErrors.init_network_graph)
 
+        val graphNodes = graph.list_nodes().map { it.as_slice().hexEncodedString() }
+
+        //Filter out nodes we don't know about as querying unknown nodes will cause a crash
+        val includedList: List<String> = nodeIds.toArrayList().map { it as String }.filter { graphNodes.contains(it) }
+
         val list = Arguments.createArray()
-        //TODO
-        //        val id = NodeId.from_pubkey(nodeId.hexa())
+        includedList.forEach {
+            val node = graph.node(NodeId.from_pubkey(it.hexa()))?.asJson
+            if (node != null) {
+                node.putString("id", it)
+                list.pushMap(node)
+            }
+        }
+
         promise.resolve(list)
     }
 

lib/ios/Ldk.swift

@@ -852,9 +852,11 @@ class Ldk: NSObject {
             return handleReject(reject, .init_network_graph)
         }
 
+        let graphNodes = networkGraph.list_nodes().map { Data($0.as_slice()).hexEncodedString() }
+        
         //Filter out nodes we don't know about as querying unknown nodes will cause a crash
         let includedList = nodeIds.map({ $0 as! String }).filter { id in
-            return networkGraph.list_nodes().contains { id == Data($0.as_slice()).hexEncodedString() }
+            return graphNodes.contains { id == $0 }
         }
 
         return resolve(includedList.map({ id in