Code cleanup

Author: Jasonvdb

.github/workflows/e2e-ios.yml

@@ -10,9 +10,6 @@ jobs:
     name: Run e2e iOS test
     runs-on: macOS-latest
     timeout-minutes: 30
-    defaults:
-      run:
-        working-directory: example
 
     steps:
       - name: Check out Git repository
@@ -23,39 +20,58 @@ jobs:
         with:
           node-version: 14
 
-      - name: Cache node modules
+      - name: Cache lib node modules
         uses: actions/cache@v3
-        id: npmcache
+        id: lib-npmcache
         with:
           path: node_modules
           key: node-modules-${{ hashFiles('**/yarn.lock') }}
 
+      - name: Install lib dependencies
+        if: steps.lib-npmcache.outputs.cache-hit != 'true'
+        run: yarn install
+
+      - name: Build lib
+        run: yarn build
+
+      - name: Cache app node modules
+        uses: actions/cache@v3
+        id: app-npmcache
+        with:
+          path: example/node_modules
+          key: node-modules-${{ hashFiles('**/yarn.lock') }}
+
       - name: Rebuild detox
-        if: steps.npmcache.outputs.cache-hit == 'true'
+        if: steps.app-npmcache.outputs.cache-hit == 'true'
+        working-directory: example
         run: yarn detox clean-framework-cache && yarn detox build-framework-cache
 
-      - name: Install Dependencies
-        if: steps.npmcache.outputs.cache-hit != 'true'
+      - name: Install app dependencies
+        if: steps.app-npmcache.outputs.cache-hit != 'true'
+        working-directory: example
         run: yarn install
 
       - name: Cache Pods
         uses: actions/cache@v3
         id: podcache
         with:
-          path: ios/Pods
+          path: example/ios/Pods
           key: pods-${{ hashFiles('**/Podfile.lock') }}
 
-      - name: Update Pods
+      - name: Update pods and rn-nodify
         if: steps.podcache.outputs.cache-hit != 'true'
+        working-directory: example
         run: |
           gem update cocoapods xcodeproj
-          yarn ios:pods
+          yarn rn-setup
 
       - name: Install brew dependencies
         run: brew tap wix/brew && brew install applesimutils
 
       - name: Build iOS app
+        working-directory: example
         run: yarn e2e:ios-build
 
       - name: Test iOS app
+        working-directory: example
         run: sh ../.github/scripts/test-ios.sh