Skip to content

Commit f483e1f

Browse files
Remove scene and directly create nodes in _ready()
1 parent 11e5ade commit f483e1f

4 files changed

Lines changed: 25 additions & 51 deletions

File tree

addons/android_device_explorer/device_explorer.gd

Lines changed: 18 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,9 @@ const TMP_DIR := "/data/local/tmp"
88
const STORAGE_ROOT := "/storage/emulated/0"
99
const PULL_PUSH_TEMP = TMP_DIR + "/godot-device-explorer-plugin"
1010

11-
@onready var tree: Tree = $Tree
12-
@onready var devices_btn: OptionButton = $HBoxContainer/OptionButton
13-
@onready var menu_button: MenuButton = $HBoxContainer/MenuButton
11+
var tree: Tree
12+
var devices_btn: OptionButton
13+
var menu_button: MenuButton
1414

1515
var current_device := ""
1616
var show_all := false
@@ -31,22 +31,31 @@ func _ready() -> void:
3131

3232

3333
func _setup_ui() -> void:
34-
tree.hide_root = true
35-
tree.allow_rmb_select = true
36-
tree.item_collapsed.connect(_on_item_collapsed)
37-
tree.item_mouse_selected.connect(_on_item_mouse_selected)
34+
var hbox := HBoxContainer.new()
35+
add_child(hbox)
3836

37+
devices_btn = OptionButton.new()
38+
devices_btn.size_flags_horizontal = Control.SIZE_EXPAND_FILL
3939
devices_btn.custom_minimum_size = Vector2(32, 32)
40-
devices_btn.selected = -1
4140
devices_btn.pressed.connect(_load_devices)
4241
devices_btn.item_selected.connect(_on_device_selected)
42+
hbox.add_child(devices_btn)
4343

44+
menu_button = MenuButton.new()
4445
menu_button.icon = get_theme_icon("GuiTabMenuHl", "EditorIcons")
4546
var popup := menu_button.get_popup()
46-
popup.clear()
4747
popup.add_check_item("Show Full Filesystem", 0)
4848
popup.set_item_checked(0, show_all)
4949
popup.id_pressed.connect(_on_menu_item_pressed)
50+
hbox.add_child(menu_button)
51+
52+
tree = Tree.new()
53+
tree.size_flags_vertical = Control.SIZE_EXPAND_FILL
54+
tree.hide_root = true
55+
tree.allow_rmb_select = true
56+
tree.item_collapsed.connect(_on_item_collapsed)
57+
tree.item_mouse_selected.connect(_on_item_mouse_selected)
58+
add_child(tree)
5059

5160

5261
func _on_item_mouse_selected(pos: Vector2, mouse_button_index: int) -> void:

addons/android_device_explorer/device_explorer.tscn

Lines changed: 0 additions & 37 deletions
This file was deleted.

addons/android_device_explorer/plugin.gd

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,10 @@ extends EditorPlugin
44
var dock
55

66
func _enter_tree():
7-
var dock_scene = preload("res://addons/android_device_explorer/device_explorer.tscn").instantiate()
8-
7+
var dock_control = preload("res://addons/android_device_explorer/device_explorer.gd").new()
98
dock = EditorDock.new()
10-
dock.add_child(dock_scene)
11-
dock.title = "Android Device Explorer"
9+
dock.add_child(dock_control)
10+
dock.title = "Device Explorer"
1211
dock.default_slot = EditorDock.DOCK_SLOT_RIGHT_BL
1312
dock.available_layouts = EditorDock.DOCK_LAYOUT_VERTICAL | EditorDock.DOCK_LAYOUT_FLOATING
1413
add_dock(dock)

project.godot

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ config_version=5
1111
[application]
1212

1313
config/name="Android Device Explorer"
14-
run/main_scene="uid://c01i5jf0306r"
1514
config/features=PackedStringArray("4.6", "GL Compatibility")
1615
config/icon="res://icon.svg"
1716

@@ -20,6 +19,10 @@ config/icon="res://icon.svg"
2019
window/size/viewport_width=500
2120
window/size/viewport_height=884
2221

22+
[editor_plugins]
23+
24+
enabled=PackedStringArray("res://addons/android_device_explorer/plugin.cfg")
25+
2326
[physics]
2427

2528
3d/physics_engine="Jolt Physics"

0 commit comments

Comments
 (0)