fix(agent): correct nolint directive, add comment on metrics test coverage

syscod3 · syscod3 · commit 290e372b564f · 2026-03-06T23:00:10.000Z
diff --git a/internal/agent/firecracker_driver_test.go b/internal/agent/firecracker_driver_test.go
@@ -639,6 +639,9 @@ func TestFirecrackerDriver_PollMetrics(t *testing.T) {
 	case <-ctx.Done():
 		t.Fatal("pollMetrics never called Metrics RPC within timeout")
 	}
+	// SetGuestMetrics is called with the values from metricsResp after the RPC returns.
+	// Deeper assertion would require a mock collector; coverage of SetGuestMetrics
+	// itself is in TestVMMetricsCollector (metrics_test.go).
 }
 
 // fakeGuestAgentClient implements pb.GuestAgentClient for testing.

Original file line number	Diff line number	Diff line change
`@@ -639,6 +639,9 @@ func TestFirecrackerDriver_PollMetrics(t *testing.T) {`
`639`	`639`	`case <-ctx.Done():`
`640`	`640`	`t.Fatal("pollMetrics never called Metrics RPC within timeout")`
`641`	`641`	`}`
	`642`	`+ // SetGuestMetrics is called with the values from metricsResp after the RPC returns.`
	`643`	`+ // Deeper assertion would require a mock collector; coverage of SetGuestMetrics`
	`644`	`+ // itself is in TestVMMetricsCollector (metrics_test.go).`
`642`	`645`	`}`
`643`	`646`
`644`	`647`	`// fakeGuestAgentClient implements pb.GuestAgentClient for testing.`