fix(helm): separate podMonitor toggle, quote interval values

Author: syscod3

charts/imp/templates/agent/podmonitor.yaml

@@ -1,4 +1,4 @@
-{{- if .Values.metrics.serviceMonitor.enabled }}
+{{- if .Values.metrics.podMonitor.enabled }}
 apiVersion: monitoring.coreos.com/v1
 kind: PodMonitor
 metadata:
@@ -14,7 +14,7 @@ spec:
       app.kubernetes.io/component: agent
   podMetricsEndpoints:
     - port: metrics
-      interval: {{ .Values.metrics.serviceMonitor.interval }}
+      interval: {{ .Values.metrics.podMonitor.interval | quote }}
   namespaceSelector:
     matchNames:
       - {{ .Release.Namespace }}

charts/imp/templates/operator/servicemonitor.yaml

@@ -14,7 +14,7 @@ spec:
       app.kubernetes.io/component: operator
   endpoints:
     - port: metrics
-      interval: {{ .Values.metrics.serviceMonitor.interval }}
+      interval: {{ .Values.metrics.serviceMonitor.interval | quote }}
   namespaceSelector:
     matchNames:
       - {{ .Release.Namespace }}

charts/imp/tests/metrics_test.yaml

@@ -32,7 +32,7 @@ tests:
   - it: skips PodMonitor when disabled
     template: templates/agent/podmonitor.yaml
     set:
-      metrics.serviceMonitor.enabled: false
+      metrics.podMonitor.enabled: false
     asserts:
       - hasDocuments:
           count: 0

charts/imp/values.yaml

@@ -56,3 +56,6 @@ metrics:
   serviceMonitor:
     enabled: true
     interval: 30s
+  podMonitor:
+    enabled: true
+    interval: 30s