fix(agent): set TerminatedAt=Failed when source VM not found in snapshot reconciler

Author: syscod3

internal/agent/impvmsnapshot_reconciler.go

@@ -44,7 +44,15 @@ func (r *ImpVMSnapshotReconciler) Reconcile(ctx context.Context, req ctrl.Reques
 		Namespace: snap.Spec.SourceVMNamespace,
 		Name:      snap.Spec.SourceVMName,
 	}, vm); err != nil {
-		return ctrl.Result{}, client.IgnoreNotFound(err)
+		if client.IgnoreNotFound(err) != nil {
+			return ctrl.Result{}, err
+		}
+		// VM deleted — terminal failure, unblock next execution.
+		now := metav1.Now()
+		base := snap.DeepCopy()
+		snap.Status.Phase = "Failed"
+		snap.Status.TerminatedAt = &now
+		return ctrl.Result{}, r.Status().Patch(ctx, snap, client.MergeFrom(base))
 	}
 	if vm.Spec.NodeName != r.NodeName {
 		return ctrl.Result{}, nil

internal/agent/impvmsnapshot_reconciler_test.go

@@ -129,4 +129,16 @@ func TestSnapshotReconciler_skipsAlreadyTerminated(t *testing.T) {
 		t.Fatalf("unexpected error: %v", err)
 	}
 	_ = res // no-op
+
+	// Verify the snapshot was not mutated.
+	fetched := &impdevv1alpha1.ImpVMSnapshot{}
+	if err := c.Get(context.Background(), types.NamespacedName{Name: "snap-child", Namespace: "default"}, fetched); err != nil {
+		t.Fatalf("get snap: %v", err)
+	}
+	if fetched.Status.Phase != "Succeeded" {
+		t.Errorf("expected phase=Succeeded, got %q", fetched.Status.Phase)
+	}
+	if fetched.Status.TerminatedAt == nil {
+		t.Error("expected TerminatedAt to remain set")
+	}
 }