fix(helm): agent DaemonSet — CharDevice type, updateStrategy, tolerations, test coverage

Author: syscod3

charts/imp/templates/agent/daemonset.yaml

@@ -11,6 +11,8 @@ spec:
     matchLabels:
       {{- include "imp.selectorLabels" . | nindent 6 }}
       app.kubernetes.io/component: agent
+  updateStrategy:
+    {{- toYaml .Values.agent.updateStrategy | nindent 4 }}
   template:
     metadata:
       labels:
@@ -26,17 +28,21 @@ spec:
       nodeSelector:
         {{- toYaml . | nindent 8 }}
       {{- end }}
+      {{- with .Values.agent.tolerations }}
+      tolerations:
+        {{- toYaml . | nindent 8 }}
+      {{- end }}
       containers:
       - name: agent
         image: {{ include "imp.agent.image" . }}
-        imagePullPolicy: {{ .Values.agent.image.pullPolicy }}
+        imagePullPolicy: {{ .Values.agent.image.pullPolicy | quote }}
         env:
         - name: NODE_NAME
           valueFrom:
             fieldRef:
               fieldPath: spec.nodeName
         - name: FC_KERNEL
-          value: {{ required "agent.env.kernelPath is required" .Values.agent.env.kernelPath | quote }}
+          value: {{ .Values.agent.env.kernelPath | required "agent.env.kernelPath is required" | quote }}
         resources:
           {{- toYaml .Values.agent.resources | nindent 10 }}
         securityContext:
@@ -52,17 +58,21 @@ spec:
       - name: dev-kvm
         hostPath:
           path: /dev/kvm
+          type: CharDevice
       - name: socket-dir
         {{- if .Values.agent.hostPaths.socketDir.enabled }}
         hostPath:
-          path: {{ .Values.agent.hostPaths.socketDir.path }}
+          path: {{ .Values.agent.hostPaths.socketDir.path | quote }}
+          type: DirectoryOrCreate
         {{- else }}
         emptyDir: {}
         {{- end }}
       - name: image-cache
         {{- if .Values.agent.hostPaths.imageCache.enabled }}
         hostPath:
-          path: {{ .Values.agent.hostPaths.imageCache.path }}
+          path: {{ .Values.agent.hostPaths.imageCache.path | quote }}
+          type: DirectoryOrCreate
         {{- else }}
         emptyDir: {}
         {{- end }}
+      terminationGracePeriodSeconds: 10

charts/imp/tests/agent-daemonset_test.yaml

@@ -30,6 +30,7 @@ tests:
             name: dev-kvm
             hostPath:
               path: /dev/kvm
+              type: CharDevice
 
   - it: uses emptyDir for socketDir when hostPaths disabled
     template: templates/agent/daemonset.yaml
@@ -56,6 +57,7 @@ tests:
             name: socket-dir
             hostPath:
               path: /run/imp/sockets
+              type: DirectoryOrCreate
 
   - it: uses emptyDir for imageCache when hostPaths disabled
     template: templates/agent/daemonset.yaml
@@ -82,3 +84,37 @@ tests:
             name: image-cache
             hostPath:
               path: /var/lib/imp/images
+              type: DirectoryOrCreate
+
+  - it: runs agent container with privileged security context
+    template: templates/agent/daemonset.yaml
+    set:
+      agent.env.kernelPath: /usr/local/bin/firecracker
+    asserts:
+      - equal:
+          path: spec.template.spec.containers[0].securityContext.privileged
+          value: true
+
+  - it: injects NODE_NAME from downward API
+    template: templates/agent/daemonset.yaml
+    set:
+      agent.env.kernelPath: /usr/local/bin/firecracker
+    asserts:
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: NODE_NAME
+            valueFrom:
+              fieldRef:
+                fieldPath: spec.nodeName
+
+  - it: sets FC_KERNEL from kernelPath value
+    template: templates/agent/daemonset.yaml
+    set:
+      agent.env.kernelPath: /host/boot/vmlinux
+    asserts:
+      - contains:
+          path: spec.template.spec.containers[0].env
+          content:
+            name: FC_KERNEL
+            value: /host/boot/vmlinux

charts/imp/values.yaml

@@ -30,6 +30,11 @@ agent:
     limits:
       memory: 128Mi
   nodeSelector: {}
+  tolerations: []
+  updateStrategy:
+    type: RollingUpdate
+    rollingUpdate:
+      maxUnavailable: 1
   env:
     kernelPath: ""
   hostPaths: