feat(api): ImpVMSnapshot — NodeLocalSpec, BaseSnapshot election, TerminatedAt, retention bounds

Author: syscod3

api/v1alpha1/impvmsnapshot_types.go

@@ -18,13 +18,22 @@ type ImpVMSnapshotSpec struct {
 	// +optional
 	Schedule string `json:"schedule,omitempty"`
 
-	// Retention is the number of completed snapshots to keep (oldest pruned first).
+	// Retention is the number of completed executions to keep (oldest pruned first).
 	// +optional
 	// +kubebuilder:default=3
+	// +kubebuilder:validation:Minimum=1
+	// +kubebuilder:validation:Maximum=10
 	Retention int32 `json:"retention,omitempty"`
 
 	// Storage defines where the snapshot artifact is persisted.
 	Storage SnapshotStorageSpec `json:"storage"`
+
+	// BaseSnapshot pins a specific child execution as the elected base image.
+	// Set declaratively or via `kubectl imp elect`.
+	// Consumers (ImpWarmPool, ImpVMMigration) use this as their boot source.
+	// The operator validates the named child exists and has phase=Succeeded.
+	// +optional
+	BaseSnapshot string `json:"baseSnapshot,omitempty"`
 }
 
 // SnapshotStorageSpec configures snapshot artifact storage.
@@ -33,12 +42,25 @@ type SnapshotStorageSpec struct {
 	// +kubebuilder:validation:Enum=node-local;oci-registry
 	Type string `json:"type"`
 
+	// NodeLocal configures node-local artifact storage.
+	// Required when Type is "node-local".
+	// +optional
+	NodeLocal *NodeLocalSpec `json:"nodeLocal,omitempty"`
+
 	// OCIRegistry configures an OCI registry destination.
 	// Required when Type is "oci-registry".
 	// +optional
 	OCIRegistry *OCIRegistrySpec `json:"ociRegistry,omitempty"`
 }
 
+// NodeLocalSpec configures node-local snapshot storage.
+type NodeLocalSpec struct {
+	// Path is the base directory for snapshot artifacts on the node.
+	// Supports remotely-mounted paths (NFS, etc.).
+	// +kubebuilder:default="/var/lib/imp/snapshots"
+	Path string `json:"path,omitempty"`
+}
+
 // OCIRegistrySpec configures OCI registry access for snapshot storage.
 type OCIRegistrySpec struct {
 	// Repository is the full image reference prefix
@@ -72,6 +94,21 @@ type ImpVMSnapshotStatus struct {
 	// +optional
 	NextScheduledAt *metav1.Time `json:"nextScheduledAt,omitempty"`
 
+	// LastExecutionRef is the most recently created child execution object.
+	// +optional
+	LastExecutionRef *corev1.LocalObjectReference `json:"lastExecutionRef,omitempty"`
+
+	// BaseSnapshot mirrors spec.baseSnapshot once the referenced child is
+	// validated as Succeeded. Consumers read this field only.
+	// +optional
+	BaseSnapshot string `json:"baseSnapshot,omitempty"`
+
+	// TerminatedAt is set by the agent once the execution reaches a terminal
+	// state (Succeeded or Failed) and all cleanup is complete.
+	// The operator uses this — not phase alone — to gate new execution creation.
+	// +optional
+	TerminatedAt *metav1.Time `json:"terminatedAt,omitempty"`
+
 	// Conditions follow the standard k8s condition convention.
 	// +optional
 	// +listType=map

config/crd/bases/imp.dev_impvmsnapshots.yaml

@@ -58,11 +58,20 @@ spec:
           spec:
             description: ImpVMSnapshotSpec defines the desired snapshot.
             properties:
+              baseSnapshot:
+                description: |-
+                  BaseSnapshot pins a specific child execution as the elected base image.
+                  Set declaratively or via `kubectl imp elect`.
+                  Consumers (ImpWarmPool, ImpVMMigration) use this as their boot source.
+                  The operator validates the named child exists and has phase=Succeeded.
+                type: string
               retention:
                 default: 3
-                description: Retention is the number of completed snapshots to keep
+                description: Retention is the number of completed executions to keep
                   (oldest pruned first).
                 format: int32
+                maximum: 10
+                minimum: 1
                 type: integer
               schedule:
                 description: |-
@@ -78,6 +87,18 @@ spec:
               storage:
                 description: Storage defines where the snapshot artifact is persisted.
                 properties:
+                  nodeLocal:
+                    description: |-
+                      NodeLocal configures node-local artifact storage.
+                      Required when Type is "node-local".
+                    properties:
+                      path:
+                        default: /var/lib/imp/snapshots
+                        description: |-
+                          Path is the base directory for snapshot artifacts on the node.
+                          Supports remotely-mounted paths (NFS, etc.).
+                        type: string
+                    type: object
                   ociRegistry:
                     description: |-
                       OCIRegistry configures an OCI registry destination.
@@ -123,6 +144,11 @@ spec:
           status:
             description: ImpVMSnapshotStatus reflects the observed state.
             properties:
+              baseSnapshot:
+                description: |-
+                  BaseSnapshot mirrors spec.baseSnapshot once the referenced child is
+                  validated as Succeeded. Consumers read this field only.
+                type: string
               completedAt:
                 description: CompletedAt is the time the last snapshot completed.
                 format: date-time
@@ -191,6 +217,21 @@ spec:
                 description: Digest is the OCI digest of the produced artifact (oci-registry
                   only).
                 type: string
+              lastExecutionRef:
+                description: LastExecutionRef is the most recently created child execution
+                  object.
+                properties:
+                  name:
+                    default: ""
+                    description: |-
+                      Name of the referent.
+                      This field is effectively required, but due to backwards compatibility is
+                      allowed to be empty. Instances of this type with an empty value here are
+                      almost certainly wrong.
+                      More info: https://kubernetes.io/docs/concepts/overview/working-with-objects/names/#names
+                    type: string
+                type: object
+                x-kubernetes-map-type: atomic
               nextScheduledAt:
                 description: NextScheduledAt is when the next scheduled snapshot will
                   run.
@@ -203,6 +244,13 @@ spec:
                 description: SnapshotPath is the node-local path of the snapshot artifact
                   (node-local only).
                 type: string
+              terminatedAt:
+                description: |-
+                  TerminatedAt is set by the agent once the execution reaches a terminal
+                  state (Succeeded or Failed) and all cleanup is complete.
+                  The operator uses this — not phase alone — to gate new execution creation.
+                format: date-time
+                type: string
             type: object
         type: object
     served: true