Skip to content

Commit e46743c

Browse files
committed
feat(agent): grant impnetworks list/watch/status-patch RBAC and add NODE_IP env
1 parent 5141f98 commit e46743c

4 files changed

Lines changed: 18 additions & 2 deletions

File tree

charts/imp/templates/agent/clusterrole.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,11 @@ rules:
2020
- apiGroups: ["imp.dev"]
2121
resources:
2222
- impnetworks
23-
verbs: [get]
23+
verbs: [get, list, watch]
24+
- apiGroups: ["imp.dev"]
25+
resources:
26+
- impnetworks/status
27+
verbs: [get, update, patch]
2428
- apiGroups: [""]
2529
resources:
2630
- events

charts/imp/templates/agent/daemonset.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,10 @@ spec:
4141
valueFrom:
4242
fieldRef:
4343
fieldPath: spec.nodeName
44+
- name: NODE_IP
45+
valueFrom:
46+
fieldRef:
47+
fieldPath: status.hostIP
4448
- name: FC_KERNEL
4549
value: {{ .Values.agent.env.kernelPath | required "agent.env.kernelPath is required" | quote }}
4650
ports:

charts/imp/tests/agent-rbac_test.yaml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,13 @@ tests:
4444
content:
4545
apiGroups: ["imp.dev"]
4646
resources: [impnetworks]
47-
verbs: [get]
47+
verbs: [get, list, watch]
48+
- contains:
49+
path: rules
50+
content:
51+
apiGroups: ["imp.dev"]
52+
resources: [impnetworks/status]
53+
verbs: [get, update, patch]
4854
- contains:
4955
path: rules
5056
content:

internal/agent/reconciler.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,8 @@ type ImpVMReconciler struct {
3535

3636
// +kubebuilder:rbac:groups=imp.dev,resources=impvms,verbs=get;list;watch;update;patch
3737
// +kubebuilder:rbac:groups=imp.dev,resources=impvms/status,verbs=get;update;patch
38+
// +kubebuilder:rbac:groups=imp.dev,resources=impnetworks,verbs=get;list;watch
39+
// +kubebuilder:rbac:groups=imp.dev,resources=impnetworks/status,verbs=get;update;patch
3840

3941
func (r *ImpVMReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {
4042
log := logf.FromContext(ctx).WithValues("node", r.NodeName)

0 commit comments

Comments
 (0)