Added more Tests/UndoTestDoublesTests.class.sql to make sure that constraints and triggers work and added a test to check that that RenamedObjectLog table is empty after Undo. SSPs, Views, and Functions next.

Author: lizbaron

Source/tSQLt.UndoTestDoubles.ssp.sql

@@ -6,6 +6,11 @@ CREATE PROCEDURE tSQLt.UndoTestDoubles
 AS
 BEGIN
   DECLARE @cmd NVARCHAR(MAX);
+
+  SELECT TOP(0)A.* INTO #RenamedObjects FROM tSQLt.Private_RenamedObjectLog A RIGHT JOIN tSQLt.Private_RenamedObjectLog X ON 1=0;
+
+  BEGIN TRAN;
+  DELETE FROM tSQLt.Private_RenamedObjectLog OUTPUT Deleted.* INTO #RenamedObjects;
   WITH L AS
   (
     SELECT 
@@ -17,10 +22,10 @@ BEGIN
         OBJECT_NAME(ROL.ObjectId) CurrentName,
         PARSENAME(ROL.OriginalName,1) OriginalName,
         O.type ObjectType
-      FROM tSQLt.Private_RenamedObjectLog ROL
+      FROM #RenamedObjects ROL
       JOIN sys.objects O
         ON ROL.ObjectId = O.object_id
-      LEFT JOIN tSQLt.Private_RenamedObjectLog ParentROL
+      LEFT JOIN #RenamedObjects ParentROL
         ON O.parent_object_id = ParentROL.ObjectId
   )
   SELECT @cmd = 
@@ -34,6 +39,7 @@ BEGIN
        FOR XML PATH(''),TYPE
   ).value('.','NVARCHAR(MAX)')
   EXEC(@cmd);
+  COMMIT;
 END;
 GO
 

Tests/UndoTestDoublesTests.class.sql

@@ -134,14 +134,93 @@ BEGIN
 
 END;
 GO
+CREATE PROCEDURE UndoTestDoublesTests.CreateTableWithTriggersAndConstraints
+  @Number NVARCHAR(MAX)
+AS
+BEGIN
+  DECLARE @cmd NVARCHAR(MAX);
+  SELECT @cmd = 'CREATE TABLE UndoTestDoublesTests.aSimpleTable0 ( Id INT CONSTRAINT aSimpleTable0C1 CHECK(Id > 9) CONSTRAINT aSimpleTable0PK PRIMARY KEY);';
+  SET @cmd = REPLACE(@cmd,'0',@Number);EXEC(@cmd);
+
+  SET @cmd = 'CREATE TRIGGER aSimpleTrigger0i ON UndoTestDoublesTests.aSimpleTable0 FOR INSERT AS RETURN;';
+  SET @cmd = REPLACE(@cmd,'0',@Number);EXEC(@cmd);
+
+  SET @cmd = 'CREATE TRIGGER aSimpleTrigger0u ON UndoTestDoublesTests.aSimpleTable0 FOR UPDATE AS RETURN;';
+  SET @cmd = REPLACE(@cmd,'0',@Number);EXEC(@cmd);
+
+END;
+GO
+CREATE PROCEDURE UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints
+  @Number NVARCHAR(MAX)
+AS
+BEGIN
+  DECLARE @cmd NVARCHAR(MAX);
+  SELECT @cmd = '
+    EXEC tSQLt.FakeTable @TableName=''UndoTestDoublesTests.aSimpleTable0'';
+    EXEC tSQLt.ApplyConstraint @TableName=''UndoTestDoublesTests.aSimpleTable0'', @ConstraintName = ''aSimpleTable0C1'';
+    EXEC tSQLt.ApplyConstraint @TableName=''UndoTestDoublesTests.aSimpleTable0'', @ConstraintName = ''aSimpleTable0PK'';
+    EXEC tSQLt.ApplyTrigger @TableName=''UndoTestDoublesTests.aSimpleTable0'', @TriggerName = ''aSimpleTrigger0i'';
+    EXEC tSQLt.ApplyTrigger @TableName=''UndoTestDoublesTests.aSimpleTable0'', @TriggerName = ''aSimpleTrigger0u'';
+  ';
+  SET @cmd = REPLACE(@cmd,'0',@Number);EXEC(@cmd);
+
+END;
+GO
+CREATE PROCEDURE UndoTestDoublesTests.[test restores multiple triggers and multiple constraints on multiple tables faked multiple times]
+AS
+BEGIN
+  EXEC UndoTestDoublesTests.CreateTableWithTriggersAndConstraints '1';
+  EXEC UndoTestDoublesTests.CreateTableWithTriggersAndConstraints '2';
+  EXEC UndoTestDoublesTests.CreateTableWithTriggersAndConstraints '3';
+
+  SELECT X.ObjectName, OBJECT_ID('UndoTestDoublesTests.'+X.ObjectName) ObjectId
+    INTO #OriginalObjectIds
+    FROM (VALUES('aSimpleTrigger1i'),('aSimpleTrigger1u'),('aSimpleTable1C1'),('aSimpleTable1PK'),('aSimpleTable1'),
+                ('aSimpleTrigger2i'),('aSimpleTrigger2u'),('aSimpleTable2C1'),('aSimpleTable2PK'),('aSimpleTable2'),
+                ('aSimpleTrigger3i'),('aSimpleTrigger3u'),('aSimpleTable3C1'),('aSimpleTable3PK'),('aSimpleTable3')
+    ) X (ObjectName);
+
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '1';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '2';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '3';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '1';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '2';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '3';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '1';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '2';
+  EXEC UndoTestDoublesTests.FakeTableAndApplyTriggersAndConstraints '3';
+
+  EXEC tSQLt.UndoTestDoubles;
+
+  SELECT X.ObjectName, OBJECT_ID('UndoTestDoublesTests.'+X.ObjectName) ObjectId
+    INTO #RestoredObjectIds
+    FROM (VALUES('aSimpleTrigger1i'),('aSimpleTrigger1u'),('aSimpleTable1C1'),('aSimpleTable1PK'),('aSimpleTable1'),
+                ('aSimpleTrigger2i'),('aSimpleTrigger2u'),('aSimpleTable2C1'),('aSimpleTable2PK'),('aSimpleTable2'),
+                ('aSimpleTrigger3i'),('aSimpleTrigger3u'),('aSimpleTable3C1'),('aSimpleTable3PK'),('aSimpleTable3')
+    ) X (ObjectName);
+
+  EXEC tSQLt.AssertEqualsTable @Expected = '#OriginalObjectIds', @Actual = '#RestoredObjectIds';
+
+END;
+GO
+CREATE PROCEDURE UndoTestDoublesTests.[test tSQLt.Private_RenamedObjectLog is empty after execution]
+AS
+BEGIN
+  CREATE TABLE UndoTestDoublesTests.aSimpleTable ( Id INT );
+
+  EXEC tSQLt.FakeTable @TableName = 'UndoTestDoublesTests.aSimpleTable';
+
+  EXEC tSQLt.UndoTestDoubles;
+
+  EXEC tSQLt.AssertEmptyTable @TableName = 'tSQLt.Private_RenamedObjectLog';
+END;
+GO
+
 /*--
 TODO
-==> multiple constraints and triggers on a multiple tables, faked multiple times
 - stored procedures
 - views
 - functions
-
-
-Also, just review all the code.
+- rename object to unique name
 
 --*/