Skip to content

Commit 52261a5

Browse files
committed
Clean up TODOs; Organize around what needs to be finished
1 parent 02f0a06 commit 52261a5

5 files changed

Lines changed: 10 additions & 17 deletions

Tests/AnnotationNoTransactionTests.class.sql

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -425,7 +425,7 @@ BEGIN
425425
--ROLLBACK
426426
END;
427427
GO
428-
---[@tSQLt:SkipTest]('')
428+
429429
--[@tSQLt:NoTransaction]('AnnotationNoTransactionTests.[CLEANUP: test an unrecoverable erroring test gets correct (Success/Failure but not Error) entry in TestResults table]')
430430
/* This test must be NoTransaction because the inner test will invalidate any open transaction causing chaos and turmoil in the reactor. */
431431
CREATE PROCEDURE AnnotationNoTransactionTests.[test an unrecoverable erroring test gets correct entry in TestResults table]
@@ -1579,10 +1579,3 @@ END;
15791579
GO
15801580
/*-----------------------------------------------------------------------------------------------*/
15811581
GO
1582-
1583-
/*-- TODO
1584-
1585-
Mark NoTransaction tests somehow in TestResult
1586-
1587-
--*/
1588-

Tests/InfoTests.class.sql

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,5 +159,3 @@ BEGIN
159159
EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
160160
END;
161161

162-
--TODO:
163-
-- include minimum supported version, like column with the lowest number that we run CI tests on (hardcoded)

Tests/Private_NoTransactionHandleTableTests.class.sql

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -579,7 +579,10 @@ GO
579579
GO
580580

581581

582-
582+
CREATE PROCEDURE Private_NoTransactionHandleTableTests.[test TODO]
583+
AS
584+
BEGIN
585+
EXEC tSQLt.Fail 'TODO';
583586
--tSQLt.Run 'Private_NoTransactionHandleTableTests'.[test if @TableAction is Restore, @Action Save, Save: the second Save does nothing]'
584587
/*--
585588
TODO
@@ -616,3 +619,7 @@ Some scenarios to consider
616619
16: ?*test* Save (Ignore), Save (Ignore), Reset (Ignore), Reset (Ignore) --> No Op. ExpectNoException.s
617620
618621
--*/
622+
END;
623+
GO
624+
/*-----------------------------------------------------------------------------------------------*/
625+
GO

Tests/UndoTestDoublesTests.class.sql

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -822,8 +822,3 @@ GO
822822
/*-----------------------------------------------------------------------------------------------*/
823823
GO
824824

825-
/*--
826-
TODO
827-
828-
--*/
829-
--EXEC tSQLt.Run UndoTestDoublesTests

Tests/_ExploratoryTests.class.sql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ GO
357357
--CREATE PROCEDURE [_ExploratoryTests].[test TBD]
358358
--AS
359359
--BEGIN
360-
-- EXEC tSQLt.Fail 'TODO';
360+
-- EXEC tSQLt.Fail 'TemplateTest';
361361
--END;
362362
GO
363363
/*-----------------------------------------------------------------------------------------------*/

0 commit comments

Comments
 (0)