Added double ledger test for Private_Results view; Test for Private_CleanUpCmdHandler; Completed(!?) tests for Private_HandleMessageAndResult; More AnnotationNoTransactionTests.

Author: lizbaron

Source/tSQLt.Private_CleanUpCmdHandler.ssp.sql

@@ -12,9 +12,6 @@ BEGIN
     EXEC(@CleanUpCmd);
   END TRY
   BEGIN CATCH
-    --SET @TestMsg = (CASE WHEN @TestMsg <> '' THEN @TestMsg + ' [Result: '+ ISNULL(@TestResult,'<NULL>') + '] || ' ELSE '' END) + 'Error during clean up: (' + (SELECT FormattedError FROM tSQLt.Private_GetFormattedErrorInfo())  + ')';
-    --SET @TestResult = @ResultInCaseOfError;
-    
     DECLARE @NewMsg NVARCHAR(MAX) = 'Error during clean up: (' + (SELECT FormattedError FROM tSQLt.Private_GetFormattedErrorInfo())  + ')';
     SELECT @TestMsg = Message, @TestResult = Result FROM tSQLt.Private_HandleMessageAndResult(@TestMsg /*PrevMsg*/, @TestResult /*PrevResult*/, @NewMsg /*NewMsg*/, @ResultInCaseOfError /*NewResult*/);
   END CATCH;

Source/tSQLt.Private_HandleMessageAndResult.sfn.sql

@@ -11,7 +11,7 @@ CREATE FUNCTION tSQLt.Private_HandleMessageAndResult (
 RETURNS TABLE
 AS
 RETURN
-  SELECT CASE WHEN @PrevMessage NOT LIKE '%[^ '+CHAR(9)+']%' AND @PrevResult = 'Success' THEN '' 
+  SELECT CASE WHEN ISNULL(@PrevMessage,'') NOT LIKE '%[^ '+CHAR(9)+']%' AND @PrevResult = 'Success' THEN '' 
               ELSE CASE WHEN @PrevMessage NOT LIKE '%[^ '+CHAR(9)+']%' THEN '<empty>' ELSE ISNULL(@PrevMessage,'<NULL>') END+' [Result: '+
                    CASE WHEN @PrevResult NOT LIKE '%[^ '+CHAR(9)+']%' THEN '<empty>' ELSE ISNULL(@PrevResult,'<NULL>') END+'] || ' 
          END+

Tests/AnnotationNoTransactionTests.class.sql

@@ -1513,7 +1513,7 @@ END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
-CREATE PROCEDURE AnnotationNoTransactionTests.[test Private_AssertNoSideEffects is executed after all CleanUps and throws an error if they are new, missing, or renamed objects]
+CREATE PROCEDURE AnnotationNoTransactionTests.[test Private_AssertNoSideEffects is executed after all CleanUps and throws an error if there are new/missing/renamed objects]
 AS
 BEGIN
   EXEC tSQLt.NewTestClass 'MyInnerTests'
@@ -1545,13 +1545,29 @@ GO
 CREATE PROCEDURE AnnotationNoTransactionTests.[test Private-CleanUp when @Result = FATAL, it is not overwritten by another Result]
 AS
 BEGIN
-  EXEC tSQLt.Fail 'TODO';
+  EXEC tSQLt.NewTestClass 'MyInnerTests'
+  EXEC('
+    --[@'+'tSQLt:NoTransaction](DEFAULT)
+    CREATE PROCEDURE MyInnerTests.[test1]
+    AS
+    BEGIN
+      RETURN;
+    END;
+  ');
+  EXEC tSQLt.SpyProcedure @ProcedureName = 'tSQLt.Private_NoTransactionHandleTables', @CommandToExecute = 'IF(@Action=''Reset'')RAISERROR(''AFatalError'',16,10);';
+  EXEC tSQLt.SpyProcedure @ProcedureName = 'tSQLt.UndoTestDoubles', @CommandToExecute = 'RAISERROR(''AnAbortError'',16,10);';
+
+  EXEC tSQLt.SetSummaryError 0;
+  EXEC tSQLt.Run 'MyInnerTests.[test1]';
+
+  DECLARE @Actual NVARCHAR(MAX) = (SELECT Result FROM tSQLt.TestResult);
+
+  EXEC tSQLt.AssertEqualsString @Expected = 'FATAL', @Actual = @Actual;
 END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
---[@tSQLt:SkipTest]('TODO')
-CREATE PROCEDURE AnnotationNoTransactionTests.[test Private-CleanUp @Result is not overwritten by an error in Private_AssertNoSideEffects]
+CREATE PROCEDURE AnnotationNoTransactionTests.[test Private_AssertNoSideEffects is using Private_CleanUpCmdHandler]
 AS
 BEGIN
   EXEC tSQLt.Fail 'TODO';

Tests/Private_CleanUpCmdHandlerTests.class.sql

@@ -1,10 +1,44 @@
 EXEC tSQLt.NewTestClass 'Private_CleanUpCmdHandlerTests';
 GO
-/* What is 
-*/
-CREATE PROCEDURE Private_CleanUpCmdHandlerTests.[test TODO]
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+CREATE FUNCTION Private_CleanUpCmdHandlerTests.[return 42134213 if correct error]()
+RETURNS TABLE
+AS
+RETURN
+  SELECT '9999' + ERROR_MESSAGE() FormattedError;
+GO
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+CREATE FUNCTION Private_CleanUpCmdHandlerTests.[return 42424242+@NewMessage, @NewResult](
+  @PrevMessage NVARCHAR(MAX),
+  @PrevResult NVARCHAR(MAX),
+  @NewMessage NVARCHAR(MAX),
+  @NewResult NVARCHAR(MAX)
+)
+RETURNS TABLE
+AS
+RETURN
+  SELECT @PrevResult+':7777:'+@NewMessage Message, @NewResult Result
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+CREATE PROCEDURE Private_CleanUpCmdHandlerTests.[test is using the two error functions correctly]
 AS
 BEGIN
-  EXEC tSQLt.Fail 'TODO';
+  EXEC tSQLt.FakeFunction @FunctionName = 'tSQLt.Private_GetFormattedErrorInfo', @FakeFunctionName = 'Private_CleanUpCmdHandlerTests.[return 42134213 if correct error]';
+  EXEC tSQLt.FakeFunction @FunctionName = 'tSQLt.Private_HandleMessageAndResult', @FakeFunctionName = 'Private_CleanUpCmdHandlerTests.[return 42424242+@NewMessage, @NewResult]';
+
+  DECLARE @TestResult NVARCHAR(MAX) = 'PrevResult';
+  DECLARE @TestMessage NVARCHAR(MAX) = 'PrevMessage';
+  EXEC tSQLt.Private_CleanUpCmdHandler @CleanUpCmd = 'RAISERROR(''ACleanUpError'',16,10);', @TestResult=@TestResult OUT, @TestMsg = @TestMessage OUT, @ResultInCaseOfError = 'NewResult';
+
+  SELECT @TestMessage Message, @TestResult Result INTO #Actual;
+  SELECT TOP(0) A.* INTO #Expected FROM #Actual A RIGHT JOIN #Actual X ON 1=0;
+  INSERT INTO #Expected VALUES('PrevResult:7777:Error during clean up: (9999ACleanUpError)','NewResult');
+
+  EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
 END;
 GO

Tests/Private_HandleMessageAndResultTests.class.sql

@@ -108,7 +108,7 @@ GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
 
-CREATE PROCEDURE Private_HandleMessageAndResultTests.[test returns @PrevResult??? if @NewResult is not known]
+CREATE PROCEDURE Private_HandleMessageAndResultTests.[test returns @PrevResult if @NewResult is not known]
 AS
 BEGIN
   EXEC tSQLt.FakeTable @TableName = 'tSQLt.Private_Results';
@@ -147,22 +147,28 @@ GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
 
-CREATE PROCEDURE Private_HandleMessageAndResultTests.[test returns ??? if @PrevResult is NULL]
+CREATE PROCEDURE Private_HandleMessageAndResultTests.[test returns only the @NewMessage if @PrevMessage is NULL and @PrevResult is Success]
 AS
 BEGIN
-  EXEC tSQLt.Fail 'TODO: what shoud this do?';
+  DECLARE @Message NVARCHAR(MAX);
+  SET @Message = (SELECT Message FROM tSQLt.Private_HandleMessageAndResult (NULL, 'Success', 'this is the new message', DEFAULT));
+  EXEC tSQLt.AssertEqualsString @Expected = 'this is the new message', @Actual = @Message;
 END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
 
-CREATE PROCEDURE Private_HandleMessageAndResultTests.[test tSQLt.Private_Results double ledger]
+CREATE PROCEDURE Private_HandleMessageAndResultTests.[test returns @NewResult if @PrevResult is NULL]
 AS
 BEGIN
-  EXEC tSQLt.Fail 'TODO: (Needs to live in its own class)';
+  EXEC tSQLt.FakeTable @TableName = 'tSQLt.Private_Results';
+  EXEC ('INSERT INTO tSQLt.Private_Results(Result, Severity)VALUES(''SomeNewResult'',3)');
+
+  DECLARE @Result NVARCHAR(MAX);
+  SET @Result = (SELECT Result FROM tSQLt.Private_HandleMessageAndResult (DEFAULT, NULL, DEFAULT, 'SomeNewResult'));
+  EXEC tSQLt.AssertEqualsString @Expected = 'SomeNewResult', @Actual = @Result;
 END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
 
- 

Tests/Private_ResultsTests.class.sql

@@ -0,0 +1,19 @@
+EXEC tSQLt.NewTestClass 'Private_ResultsTests';
+GO
+CREATE PROCEDURE Private_ResultsTests.[test Contains all Result values (double ledger)]
+AS
+BEGIN
+  SELECT Severity, Result INTO #Actual FROM tSQLt.Private_Results;
+
+  SELECT TOP(0) A.* INTO #Expected FROM #Actual A RIGHT JOIN #Actual X ON 1=0;
+  INSERT INTO #Expected
+    SELECT 1,'Success' UNION ALL
+    SELECT 2,'Skipped' UNION ALL
+    SELECT 3,'Failure' UNION ALL
+    SELECT 4,'Error'   UNION ALL
+    SELECT 5,'Abort'   UNION ALL
+    SELECT 6,'FATAL'   ;
+  EXEC tSQLt.AssertEqualsTable '#Expected','#Actual';
+
+END;
+GO

Tests/Tests.ssmssqlproj

@@ -300,6 +300,12 @@
           <AssociatedConnUserName />
           <FullPath>Private_ResetNewTestClassListTests.class.sql</FullPath>
         </FileNode>
+        <FileNode Name="Private_ResultsTests.class.sql">
+          <AssociatedConnectionMoniker />
+          <AssociatedConnSrvName />
+          <AssociatedConnUserName />
+          <FullPath>Private_ResultsTests.class.sql</FullPath>
+        </FileNode>
         <FileNode Name="Private_ScriptIndexTests.class.sql">
           <AssociatedConnectionMoniker />
           <AssociatedConnSrvName />