Merge pull request #108 from tSQLt-org/FixFailedToReadTestResultXml

Fix failed to read test result xml

Author: mbt1

.github/workflows/build_and_test_on_spawn.yml

@@ -7,7 +7,8 @@ name: Build and Test tSQLt on Spawn
 on:
   push:
     branches:
-      - tSQLtFacadeBuild
+      - main
+  pull_request:
   workflow_dispatch: 
     inputs:
       spawnDataImages:

.gitignore

@@ -27,3 +27,4 @@
 /tSQLtCLR/OfficialSigningKey/KeyInfo.txt
 /tSQLtCLR/OfficialSigningKey/KeyInfoC.txt
 
+.vscode/settings.json

Build/FacadeValidate.ps1

@@ -34,8 +34,7 @@ $FriendlySQLServerVersion = Get-FriendlySQLServerVersion -ServerName $ServerName
 $FacadeFileName = $TempPath + "/tSQLt/FacadeDacpacs/tSQLtFacade."+$FriendlySQLServerVersion+".dacpac";
 
 $DacpacDatabaseName = $DatabaseName+"_dacpac";
-$AdditionalParameters = '-v NewDbName="'+$DacpacDatabaseName+'"';
-Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -FileNames "CreateBuildDb.sql" -DatabaseName 'tempdb' -AdditionalParameters $AdditionalParameters;
+Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -FileNames "CreateBuildDb.sql" -DatabaseName 'tempdb' -AdditionalParameters ('-v NewDbName="'+$DacpacDatabaseName+'"');
 
 $SqlConnectionString = Get-SqlConnectionString -ServerName $ServerNameTrimmed -Login $LoginTrimmed -DatabaseName $DacpacDatabaseName;
 & "$SqlPackagePath/sqlpackage.exe" /a:Publish /tcs:"$SqlConnectionString" /sf:"$FacadeFileName"
@@ -55,9 +54,9 @@ Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdP
 Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -Query "EXEC tSQLt_testutil.PrepMultiRunLogTable;EXEC tSQLt.SetSummaryError @SummaryError=0;" -DatabaseName $SourceDatabaseName -AdditionalParameters $AdditionalParameters;
 Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -Query "EXEC tSQLt.RunAll;" -DatabaseName $SourceDatabaseName -AdditionalParameters $AdditionalParameters;
 Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -Query "EXEC tSQLt_testutil.LogMultiRunResult 'DeployFacadeTests.sql';" -DatabaseName $SourceDatabaseName -AdditionalParameters $AdditionalParameters;
-$AdditionalParameters = '-o "'+$TestResultsPath+'"';
-Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -FileNames "GetTestResults.sql" -DatabaseName $SourceDatabaseName -AdditionalParameters $AdditionalParameters;
-Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -Query "EXEC tSQLt.SetSummaryError @SummaryError=1;EXEC tSQLt_testutil.CheckMultiRunResults @noError=1;EXEC tSQLt_testutil.StoreBuildLog @TableName='$LogTableName',@RunGroup='Facade';" -DatabaseName $SourceDatabaseName -AdditionalParameters $AdditionalParameters;
+
+Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -FileNames "GetTestResults.sql" -DatabaseName $SourceDatabaseName -AdditionalParameters ('-o "'+$TestResultsPath+'"');
+Exec-SqlFileOrQuery -ServerName $ServerNameTrimmed -Login $LoginTrimmed -SqlCmdPath $SqlCmdPath -Query "EXEC tSQLt.SetSummaryError @SummaryError=1;EXEC tSQLt_testutil.CheckMultiRunResults @noError=1;EXEC tSQLt_testutil.StoreBuildLog @TableName='$LogTableName',@RunGroup='Facade';" -DatabaseName $SourceDatabaseName;
 
 Pop-Location;
 

CI/Azure-DevOps/AZ_BuildtSQLt.yml

@@ -50,6 +50,8 @@ variables:
     value: $(Pipeline.Workspace)\$(TSQLT_REPO_DIR)\Build\output\tSQLt\public
   - name: TSQLT_VALIDATION_ARTIFACT_DIR
     value: $(Pipeline.Workspace)\$(TSQLT_REPO_DIR)\Build\output\tSQLt\validation
+  - name: TSQLT_TEST_RESULTS_ARTIFACT_DIR
+    value: $(Pipeline.Workspace)\$(TSQLT_REPO_DIR)\Build\output\tSQLt\validation\TestResults
   - name: SQLCMDPath
 #    value: 'C:\Program Files\Microsoft SQL Server\110\Tools\Binn' for vmImage: 'vs2017-win2016'
     value: 'C:\Program Files\Microsoft SQL Server\Client SDK\ODBC\170\Tools\Binn'
@@ -578,6 +580,13 @@ stages:
         #buildConfiguration: # Optional
         publishRunAttachments: true # Optional
 
+    - task: PublishPipelineArtifact@1
+      name: PublishValidateOutputArtifact
+      inputs:
+        targetPath: '$(Pipeline.Workspace)/tSQLt/Build/output/Validate'
+        artifact: 'ValidateOutput_$(System.JobName)'
+        publishLocation: 'pipeline'
+
 
     - task: PowerShell@2
       name: TagArtifact