More notes to consider when we test transactions; Wrote another test for Private_NoTransactionHandleTable and confirmed that we are done with this functionality (for now).

Author: lizbaron

Source/tSQLt.Private_NoTransactionHandleTable.ssp.sql

@@ -73,8 +73,9 @@ BEGIN
       BEGIN
         EXEC('DELETE FROM ' + @FullTableName +';');
       END;
-      ELSE IF (@TableAction IN ('Ignore','Hide'))
+      ELSE IF (@TableAction IN ('Ignore','Hide')) 
       BEGIN
+        /* Hidden tables will be restored by UndoTestDoubles. */
         RETURN;
       END;
       ELSE

Tests/Private_NoTransactionHandleTableTests.class.sql

@@ -577,49 +577,69 @@ END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
 GO
-
-
-CREATE PROCEDURE Private_NoTransactionHandleTableTests.[test TODO]
+CREATE PROCEDURE Private_NoTransactionHandleTableTests.[test if @TableAction is Hide, @Action Save, Save: do nothing on second save]
 AS
 BEGIN
-  EXEC tSQLt.Fail 'TODO';
---tSQLt.Run 'Private_NoTransactionHandleTableTests'.[test if @TableAction is Restore, @Action Save, Save: the second Save does nothing]'
-/*--
-TODO
-
-I can rerun them and nothing "bad" happens. But what is "bad"?
-What about when I intersperse calls to Save/Reset with UndoTestDoubles?
+  CREATE TABLE Private_NoTransactionHandleTableTests.Table1 (Id INT, col1 NVARCHAR(MAX));
+  INSERT INTO Private_NoTransactionHandleTableTests.Table1 VALUES (2,'c'), (3,'a');
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Save', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
 
-Some scenarios to consider
-1: Save, Reset
-2: Save, Save, Reset
-3: Save, Reset, Reset
-4: Save, Save, Reset, Reset
+  SELECT object_id, SCHEMA_NAME(schema_id) [schema_name], name INTO #Before FROM sys.tables; 
 
-@TableAction = Restore
-5: ?*test* Save (Restore), Save (Restore) --> The second save does nothing, because it checks the #TableBackupLog.
-6: Save (Restore), Save (Restore) Eclipsed #TableBackupLog --> The second save takes a new backup because it cannot see #TableBackupLog.
-7: ?*test* Save (Restore), Save (Restore) Eclipsed #TableBackupLog, Reset (Restore) Eclipsed #TableBackupLog, Reset (Restore) --> Should be equivalent to scenario 1.
-8: ?*test* Save (Restore), Save (Restore), Reset (Restore), Reset (Restore) --> Should be equivalent to scenario 1.
-9: ?*test* Save (Restore), Save (Restore) Eclipsed #TableBackupLog, Reset (Restore) --> Should be equivalent to scenario 1.
-17: ?*test* Save (Restore), Reset (Restore), Reset (Restore) --> Should be equivalent to scenario 1.
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Save', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
 
-@TableAction = Hide
-10: ?*test* Save (Hide), Save (Hide) --> We can't hide something we can't see. Check to see if the object is already hidden, if so do nothing. If not, throw an error.
-11: Save (Hide), Save (Hide) Eclipsed #TableBackupLog --> Same as scenario 10.
-12: Save (Hide), Save (Hide) Eclipsed #TableBackupLog, Reset (Hide) Eclipsed #TableBackupLog, Reset (Hide) --> Should be equivalent to Scenario 1.
-13: Save (Hide), Save (Hide), Reset (Hide), Reset (Hide) -->  Should be equivalent to Scenario 1.
-14: Save (Hide), Save (Hide) Eclipsed #TableBackupLog, Reset (Hide) -->  Should be equivalent to Scenario 1.
-18: Save (Hide), Reset (Hide), Reset (Hide) --> Should be equivalent to scenario 1.
+  SELECT * INTO #Actual
+    FROM (
+      (
+        SELECT 'Extra'[?],object_id, SCHEMA_NAME(schema_id) [schema_name], name FROM sys.tables
+        EXCEPT
+        SELECT 'Extra'[?],* FROM #Before
+      )
+      UNION ALL
+      (
+        SELECT 'Missing'[?],* FROM #Before
+        EXCEPT
+        SELECT 'Missing'[?],object_id, SCHEMA_NAME(schema_id) [schema_name], name FROM sys.tables
+      )
+    ) X;
+    
+  EXEC tSQLt.AssertEmptyTable @TableName = '#Actual';
+END;
+GO
+/*-----------------------------------------------------------------------------------------------*/
+GO
+CREATE PROCEDURE Private_NoTransactionHandleTableTests.[test if @TableAction is Hide, @Action Save, Save, Reset, Reset: does nothing in total]
+AS
+BEGIN
+  CREATE TABLE Private_NoTransactionHandleTableTests.Table1 (Id INT, col1 NVARCHAR(MAX));
+  INSERT INTO Private_NoTransactionHandleTableTests.Table1 VALUES (2,'c'), (3,'a');
 
-@TableAction = Truncate
-15: ?*test* Save (Truncate), Save (Truncate), Reset (Truncate), Save (Truncate), Reset (Truncate), Reset (Truncate) -->  Should be idempotent. Any table with TableAction=Truncate should be empty after any number of save, reset actions.
+  SELECT object_id, SCHEMA_NAME(schema_id) [schema_name], name INTO #Before FROM sys.tables; 
 
-@TableAction = Ignore
-16: ?*test* Save (Ignore), Save (Ignore), Reset (Ignore), Reset (Ignore) --> No Op. ExpectNoException.s
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Save', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Save', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Reset', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
+  EXEC tSQLt.Private_NoTransactionHandleTable @Action = 'Reset', @FullTableName = '[Private_NoTransactionHandleTableTests].[Table1]', @TableAction = 'Hide';
+  EXEC tSQLt.UndoTestDoubles;
 
---*/
+  SELECT * INTO #Actual
+    FROM (
+      (
+        SELECT 'Extra'[?],object_id, SCHEMA_NAME(schema_id) [schema_name], name FROM sys.tables
+        EXCEPT
+        SELECT 'Extra'[?],* FROM #Before
+      )
+      UNION ALL
+      (
+        SELECT 'Missing'[?],* FROM #Before
+        EXCEPT
+        SELECT 'Missing'[?],object_id, SCHEMA_NAME(schema_id) [schema_name], name FROM sys.tables
+      )
+    ) X;
+    
+  EXEC tSQLt.AssertEmptyTable @TableName = '#Actual';
 END;
 GO
 /*-----------------------------------------------------------------------------------------------*/
-GO
+GO
+

Tests/Run_Methods_Tests.class.sql

@@ -2496,7 +2496,8 @@ GO
   3b. New transaction after test (COMMIT, but new one created within the test)
 
   4. Transaction test renders transaction uncommitable (Won't be able to write to anything, including tSQLt.TestResults or a variety of temp tables.)
-
+   
+  - currently AssertNoSideEffects causes additional problems if executed inside an uncommittable transaction (It tries to write to a new temp table) <-- does this need to be changed?
   - do existing tests already cover some of the scenarios described above?
 
 --*/