Skip to content

Commit b407590

Browse files
committed
Fixed issues
1 parent a40d774 commit b407590

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

tableauserverclient/server/endpoint/datasources_endpoint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ def update_connections(
328328
username: Optional[str] = None,
329329
password: Optional[str] = None,
330330
embed_password: Optional[bool] = None,
331-
) -> Iterable[str]:
331+
) -> list[ConnectionItem]:
332332
"""
333333
Bulk updates one or more datasource connections by LUID.
334334
@@ -368,8 +368,8 @@ def update_connections(
368368
embed_password=embed_password,
369369
)
370370
server_response = self.put_request(url, request_body)
371-
connection_items = list(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace))
372-
updated_ids = [conn.id for conn in connection_items]
371+
connection_items = ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)
372+
updated_ids: list[str] = [conn.id for conn in connection_items]
373373

374374
logger.info(f"Updated connections for datasource {datasource_item.id}: {', '.join(updated_ids)}")
375375
return connection_items

tableauserverclient/server/endpoint/workbooks_endpoint.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -335,7 +335,7 @@ def update_connections(
335335
username: Optional[str] = None,
336336
password: Optional[str] = None,
337337
embed_password: Optional[bool] = None,
338-
) -> Iterable[str]:
338+
) -> list[ConnectionItem]:
339339
"""
340340
Bulk updates one or more workbook connections by LUID, including authenticationType, username, password, and embedPassword.
341341
@@ -377,8 +377,8 @@ def update_connections(
377377

378378
# Send request
379379
server_response = self.put_request(url, request_body)
380-
connection_items = list(ConnectionItem.from_response(server_response.content, self.parent_srv.namespace))
381-
updated_ids = [conn.id for conn in connection_items]
380+
connection_items = ConnectionItem.from_response(server_response.content, self.parent_srv.namespace)
381+
updated_ids: list[str] = [conn.id for conn in connection_items]
382382

383383
logger.info(f"Updated connections for workbook {workbook_item.id}: {', '.join(updated_ids)}")
384384
return connection_items

0 commit comments

Comments
 (0)