Skip to content

Commit a990105

Browse files
authored
Merge pull request noobaa#1860 from romayalon/romy-vectors-bucket-api
Remove vector db config from the internal RPC API
2 parents 0f2c818 + 5ea8f62 commit a990105

1 file changed

Lines changed: 9 additions & 15 deletions

File tree

pkg/nb/types.go

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -826,16 +826,10 @@ func UInt64ToBigInt(value uint64) BigInt {
826826

827827
// CreateVectorBucketParams is the params for bucket_api.create_vector_bucket()
828828
type CreateVectorBucketParams struct {
829-
Name string `json:"name"`
830-
VectorDBType nbv1.VectorDBType `json:"vector_db_type"`
831-
VectorDBConfig *VectorDBConfig `json:"vector_db_config"`
832-
BucketClaim *BucketClaimInfo `json:"bucket_claim"`
833-
}
834-
835-
// VectorDBConfig holds NamespaceResource configuration for a vector bucket.
836-
type VectorDBConfig struct {
837-
// +optional
838-
NamespaceResource *NamespaceResourceFullConfig `json:"namespace_resource,omitempty"`
829+
Name string `json:"name"`
830+
VectorDBType nbv1.VectorDBType `json:"vector_db_type"`
831+
NamespaceResource *NamespaceResourceFullConfig `json:"namespace_resource"`
832+
BucketClaim *BucketClaimInfo `json:"bucket_claim"`
839833
}
840834

841835
// DeleteVectorBucketParams is the params for bucket_api.delete_vector_bucket()
@@ -845,9 +839,9 @@ type DeleteVectorBucketParams struct {
845839

846840
// VectorBucketInfo is the info returned for a vector bucket
847841
type VectorBucketInfo struct {
848-
Name string `json:"name"`
849-
VectorDBType nbv1.VectorDBType `json:"vector_db_type,omitempty"`
850-
VectorDBConfig *VectorDBConfig `json:"vector_db_config,omitempty"`
851-
CreationTime int64 `json:"creation_time,omitempty"`
852-
BucketClaim *BucketClaimInfo `json:"bucket_claim,omitempty"`
842+
Name string `json:"name"`
843+
VectorDBType nbv1.VectorDBType `json:"vector_db_type,omitempty"`
844+
NamespaceResource *NamespaceResourceFullConfig `json:"namespace_resource,omitempty"`
845+
CreationTime int64 `json:"creation_time,omitempty"`
846+
BucketClaim *BucketClaimInfo `json:"bucket_claim,omitempty"`
853847
}

0 commit comments

Comments
 (0)