Skip to content

Commit b4c4165

Browse files
committed
fix task decorator
1 parent c212793 commit b4c4165

2 files changed

Lines changed: 9 additions & 5 deletions

File tree

taskbadger/decorators.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ def track(
1414
name: str = None,
1515
monitor_id: str = None,
1616
max_runtime: int = None,
17-
**kwargs,
17+
**task_kwargs,
1818
):
1919
"""
2020
Decorator to track a function as a task.
@@ -50,7 +50,7 @@ def _inner(*args, **kwargs):
5050
status=StatusEnum.PROCESSING,
5151
max_runtime=max_runtime,
5252
monitor_id=monitor_id,
53-
**kwargs,
53+
**task_kwargs,
5454
)
5555
try:
5656
result = func(*args, **kwargs)

tests/test_decorators.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,19 @@ def test(arg):
2020

2121
@mock.patch("taskbadger.decorators.create_task_safe")
2222
def test_track_decorator_args(create):
23-
@track(name="new name", monitor_id="test", max_runtime=1)
23+
@track(name="new name", monitor_id="test", max_runtime=1, tags={"name": "value"})
2424
def test(arg):
2525
return arg
2626

2727
assert test("test") == "test"
2828
assert create.call_count == 1
2929
assert create.call_args.args[0] == "new name"
30-
assert create.call_args.kwargs["monitor_id"] == "test"
31-
assert create.call_args.kwargs["max_runtime"] == 1
30+
assert create.call_args.kwargs == {
31+
"status": "processing",
32+
"monitor_id": "test",
33+
"max_runtime": 1,
34+
"tags": {"name": "value"},
35+
}
3236

3337

3438
@mock.patch("taskbadger.decorators.create_task_safe")

0 commit comments

Comments
 (0)