Skip to content

Commit ba50adb

Browse files
committed
fixes
1 parent 4b8b82b commit ba50adb

5 files changed

Lines changed: 30 additions & 30 deletions

File tree

taskbadger/sdk.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -18,10 +18,10 @@
1818
)
1919
from taskbadger.internal.models import (
2020
PatchedTaskRequest,
21-
PatchedTaskRequestData,
21+
PatchedTaskRequestDataType0,
2222
StatusEnum,
2323
TaskRequest,
24-
TaskRequestData,
24+
TaskRequestDataType0,
2525
)
2626
from taskbadger.internal.types import UNSET
2727
from taskbadger.mug import Badger, Session, Settings
@@ -131,10 +131,10 @@ def create_task(
131131
scope_data = Badger.current.scope().context
132132
if scope_data or data:
133133
data = data or {}
134-
task.data = TaskRequestData.from_dict({**scope_data, **data})
134+
task.data = TaskRequestDataType0.from_dict({**scope_data, **data})
135135
if actions:
136136
task.additional_properties = {"actions": [a.to_dict() for a in actions]}
137-
kwargs = _make_args(json_body=task)
137+
kwargs = _make_args(body=task)
138138
if monitor_id:
139139
kwargs["x_taskbadger_monitor"] = monitor_id
140140
with Session() as client:
@@ -179,7 +179,7 @@ def update_task(
179179
max_runtime = _none_to_unset(max_runtime)
180180
stale_timeout = _none_to_unset(stale_timeout)
181181

182-
data = UNSET if not data else PatchedTaskRequestData.from_dict(data)
182+
data = UNSET if not data else PatchedTaskRequestDataType0.from_dict(data)
183183
body = PatchedTaskRequest(
184184
name=name,
185185
status=status,
@@ -191,7 +191,7 @@ def update_task(
191191
)
192192
if actions:
193193
body.additional_properties = {"actions": [a.to_dict() for a in actions]}
194-
kwargs = _make_args(id=task_id, json_body=body)
194+
kwargs = _make_args(id=task_id, body=body)
195195
with Session() as client:
196196
response = task_partial_update.sync_detailed(client=client, **kwargs)
197197
_check_response(response)

tests/test_cli_create_update.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
PatchedTaskRequest,
1111
StatusEnum,
1212
TaskRequest,
13-
TaskRequestData,
13+
TaskRequestDataType0,
1414
)
1515
from taskbadger.internal.types import Response
1616
from tests.utils import task_for_test
@@ -19,7 +19,7 @@
1919

2020

2121
@pytest.fixture(autouse=True)
22-
def mock_env():
22+
def _mock_env():
2323
with mock.patch.dict(
2424
os.environ,
2525
{
@@ -56,13 +56,13 @@ def test_cli_create():
5656
name="my-task",
5757
status=StatusEnum.PROCESSING,
5858
value_max=100,
59-
data=TaskRequestData.from_dict({"b": "2", "a": 1, "c": 1}),
59+
data=TaskRequestDataType0.from_dict({"b": "2", "a": 1, "c": 1}),
6060
)
6161
create.assert_called_with(
6262
client=mock.ANY,
6363
organization_slug="org",
6464
project_slug="project",
65-
json_body=request,
65+
body=request,
6666
)
6767

6868

@@ -85,5 +85,5 @@ def test_cli_update():
8585
organization_slug="org",
8686
project_slug="project",
8787
id="task123",
88-
json_body=body,
88+
body=body,
8989
)

tests/test_cli_run.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
from taskbadger.cli_main import app
99
from taskbadger.internal.models import (
1010
PatchedTaskRequest,
11-
PatchedTaskRequestData,
11+
PatchedTaskRequestDataType0,
1212
StatusEnum,
1313
TaskRequest,
1414
)
@@ -49,13 +49,13 @@ def _should_update_task(last_update, update_frequency_seconds):
4949
def test_cli_capture_output():
5050
update_patch = _test_cli_run(["echo test"], 0, args=["task_name", "--capture-output"], update_call_count=2)
5151

52-
body = PatchedTaskRequest(status=UNSET, data=PatchedTaskRequestData.from_dict({"stdout": "test\n"}))
52+
body = PatchedTaskRequest(status=UNSET, data=PatchedTaskRequestDataType0.from_dict({"stdout": "test\n"}))
5353
update_patch.assert_any_call(
5454
client=mock.ANY,
5555
organization_slug="org",
5656
project_slug="project",
5757
id=mock.ANY,
58-
json_body=body,
58+
body=body,
5959
)
6060

6161

@@ -71,13 +71,13 @@ def _should_update_task(last_update, update_frequency_seconds):
7171
update_call_count=3,
7272
)
7373

74-
body = PatchedTaskRequest(status=UNSET, data=PatchedTaskRequestData.from_dict({"stdout": "test\n123\n"}))
74+
body = PatchedTaskRequest(status=UNSET, data=PatchedTaskRequestDataType0.from_dict({"stdout": "test\n123\n"}))
7575
update_patch.assert_any_call(
7676
client=mock.ANY,
7777
organization_slug="org",
7878
project_slug="project",
7979
id=mock.ANY,
80-
json_body=body,
80+
body=body,
8181
)
8282

8383

@@ -115,7 +115,7 @@ def _update(*args, **kwargs):
115115
update_mock(*args, **kwargs)
116116

117117
# handle updating task data
118-
data = kwargs["json_body"].data
118+
data = kwargs["body"].data
119119
task_return = task_for_test(id=task_id, data=data.additional_properties if data else None)
120120
return Response(HTTPStatus.OK, b"", {}, task_return)
121121

@@ -138,15 +138,15 @@ def _update(*args, **kwargs):
138138
client=mock.ANY,
139139
organization_slug="org",
140140
project_slug="project",
141-
json_body=request,
141+
body=request,
142142
)
143143

144144
if return_code == 0:
145145
body = PatchedTaskRequest(status=StatusEnum.SUCCESS, value=100)
146146
else:
147147
body = PatchedTaskRequest(
148148
status=StatusEnum.ERROR,
149-
data=PatchedTaskRequestData.from_dict({"return_code": return_code}),
149+
data=PatchedTaskRequestDataType0.from_dict({"return_code": return_code}),
150150
)
151151

152152
assert update_mock.call_count == update_call_count
@@ -155,7 +155,7 @@ def _update(*args, **kwargs):
155155
organization_slug="org",
156156
project_slug="project",
157157
id=task.id,
158-
json_body=body,
158+
body=body,
159159
)
160160
return update_mock
161161

tests/test_sdk.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
from taskbadger.exceptions import TaskbadgerException
88
from taskbadger.internal.models import (
99
PatchedTaskRequest,
10-
PatchedTaskRequestData,
10+
PatchedTaskRequestDataType0,
1111
TaskRequest,
12-
TaskRequestData,
12+
TaskRequestDataType0,
1313
)
1414
from taskbadger.internal.types import UNSET, Response
1515
from taskbadger.mug import Badger
@@ -76,7 +76,7 @@ def test_create(settings, patched_create):
7676
status=StatusEnum.PRE_PROCESSING,
7777
value=13,
7878
value_max=UNSET,
79-
data=TaskRequestData.from_dict(data),
79+
data=TaskRequestDataType0.from_dict(data),
8080
max_runtime=10,
8181
stale_timeout=2,
8282
)
@@ -93,7 +93,7 @@ def test_create(settings, patched_create):
9393
client=mock.ANY,
9494
organization_slug="org",
9595
project_slug="project",
96-
json_body=request,
96+
body=request,
9797
)
9898

9999

@@ -188,7 +188,7 @@ def _verify_update(settings, patched_update, **kwargs):
188188
request_params.update(kwargs)
189189

190190
if kwargs.get("data"):
191-
request_params["data"] = PatchedTaskRequestData.from_dict(kwargs["data"])
191+
request_params["data"] = PatchedTaskRequestDataType0.from_dict(kwargs["data"])
192192

193193
request = PatchedTaskRequest(**request_params)
194194
if actions:
@@ -200,5 +200,5 @@ def _verify_update(settings, patched_update, **kwargs):
200200
organization_slug="org",
201201
project_slug="project",
202202
id=mock.ANY,
203-
json_body=request,
203+
body=request,
204204
)

tests/utils.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,23 +2,23 @@
22
from uuid import uuid4
33

44
from taskbadger.internal.models import Task as TaskInternal
5-
from taskbadger.internal.models import TaskData
5+
from taskbadger.internal.models import TaskDataType0
66

77

88
def task_for_test(**kwargs):
99
task_id = kwargs.pop("id", uuid4().hex)
1010
data = kwargs.pop("data", None)
1111
if data:
12-
kwargs["data"] = TaskData.from_dict(data)
12+
kwargs["data"] = TaskDataType0.from_dict(data)
1313
kwargs["url"] = None
1414
kwargs["public_url"] = None
1515
kwargs["value_percent"] = None
16+
kwargs["created"] = datetime.utcnow()
17+
kwargs["updated"] = datetime.utcnow()
1618
return TaskInternal(
1719
task_id,
1820
"org",
1921
"project",
2022
"task_name",
21-
datetime.utcnow(),
22-
datetime.utcnow(),
2323
**kwargs,
2424
)

0 commit comments

Comments
 (0)