Merge pull request #18 from taskiq-python/feature/ordinary-handlers

Author: s3rius

aiohttp_deps/initializer.py

@@ -30,6 +30,15 @@ def __init__(
     ) -> None:
         self.original_handler = copy.copy(original_route)
         self.graph = DependencyGraph(self.original_handler)
+        signature = inspect.signature(self.original_handler)
+        # This flag means that the function requires one argument and
+        # doesn't depend on any other dependencies.
+        # We assume that such functions should be treated as ordinary
+        # aiohttp handlers and therefore we don't inject any dependencies
+        # and pass request object directly to the handler.
+        self.is_ordinary = False
+        if self.graph.is_empty() and len(signature.parameters) == 1:
+            self.is_ordinary = True
 
     async def __call__(self, request: web.Request) -> web.StreamResponse:
         """
@@ -41,6 +50,8 @@ async def __call__(self, request: web.Request) -> web.StreamResponse:
         :param request: current request.
         :return: response.
         """
+        if self.is_ordinary:
+            return await self.original_handler(request)
         # Hack for mypy to work
         values_overrides = request.app.get(VALUES_OVERRIDES_KEY)
         if values_overrides is None:

pyproject.toml

@@ -47,12 +47,9 @@ ruff = "^0.1.7"
 [tool.mypy]
 strict = true
 ignore_missing_imports = true
-allow_subclassing_any = true
-allow_untyped_calls = true
 pretty = true
 show_error_codes = true
 implicit_reexport = true
-allow_untyped_decorators = true
 warn_return_any = false
 warn_unused_ignores = false
 

tests/test_func_dependencies.py

@@ -79,3 +79,18 @@ async def handler(num: int = Depends(original_dep)) -> web.Response:
     resp = await client.get("/")
     assert resp.status == 200
     assert (await resp.json())["request"] == 2
+
+
+@pytest.mark.anyio
+async def test_ordinary_functions_support(
+    my_app: web.Application,
+    aiohttp_client: ClientGenerator,
+) -> None:
+    async def handler(request: web.Request) -> web.Response:
+        return web.json_response({"request": "ordinary"})
+
+    my_app.router.add_get("/", handler)
+    client = await aiohttp_client(my_app)
+    resp = await client.get("/")
+    assert resp.status == 200
+    assert await resp.json() == {"request": "ordinary"}