Merge pull request #19 from taskiq-python/feature/annotated-override

Author: s3rius

README.md

@@ -345,3 +345,20 @@ def my_function(dependency: DepType):
     pass
 
 ```
+
+Also we support overrides for annotated types.
+
+For example:
+
+```python
+from typing import Annotated
+
+DepType = Annotated[int, Depends(my_func)]
+
+def my_function(
+    dependency: DepType,
+    no_cache_dep: Annotated[DepType, Depends(my_func, use_cache=False)],
+) -> None:
+    pass
+
+```

taskiq_dependencies/graph.py

@@ -172,9 +172,14 @@ def _build_graph(self) -> None:  # noqa: C901, WPS210
             for param_name, param in sign.parameters.items():
                 default_value = param.default
                 if hasattr(param.annotation, "__metadata__"):  # noqa: WPS421
-                    for meta in param.annotation.__metadata__:
+                    # We go backwards,
+                    # because you may want to override your annotation
+                    # and the overriden value will appear to be after
+                    # the original `Depends` annotation.
+                    for meta in reversed(param.annotation.__metadata__):
                         if isinstance(meta, (Dependency, FastapiDepends)):
                             default_value = meta
+                            break
 
                 # This is for FastAPI integration. So you can
                 # use Depends from taskiq mixed with fastapi's dependencies.

tests/test_annotated.py

@@ -105,3 +105,22 @@ def test_func(dep: MyType, dep2: MyType) -> Tuple[MyType, MyType]:
         value = test_func(**(g.resolve_kwargs()))
         assert id(value[0]) == id(value[1])
         assert isinstance(value[0], TestClass)
+
+
+def test_override() -> None:
+    class TestClass:
+        pass
+
+    MyType = Annotated[TestClass, Depends()]
+
+    def test_func(
+        dep: MyType,
+        dep2: Annotated[MyType, Depends(use_cache=False)],
+    ) -> Tuple[MyType, MyType]:
+        return dep, dep2
+
+    with DependencyGraph(target=test_func).sync_ctx(exception_propagation=False) as g:
+        value = test_func(**(g.resolve_kwargs()))
+        assert id(value[0]) != id(value[1])
+        assert isinstance(value[0], TestClass)
+        assert isinstance(value[1], TestClass)