Fix review findings: extract shared traversal method, clarify docs

- Extract shared invalidateWithDependencies() from onUpdate/onDelete
- Clarify doc/2 that enabled: false is mutually exclusive with other options
- Add note to doc/3 that dependent element types must also be enabled in
  the main elements config for invalidation to take effect

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: Jan Adams

doc/2-configuration.md

@@ -12,28 +12,30 @@ neusta_pimcore_http_cache:
                 archive: false
                 unknown: false
 
-            # Invalidate dependent elements when an asset changes (disabled by default)
+            # Invalidate dependent elements when an asset changes (disabled by default).
+            # Note: a dependent element type must also be enabled above for invalidation to take effect.
             invalidate_dependencies:
                 enabled: true
                 types:
                     objects: true
                     documents: true
 
-            # Unless you disable assets completely
+            # Or disable assets completely (mutually exclusive with the options above)
             enabled: false
 
         documents:
             # By default, every type except "email", "folder" and "hardlink" is enabled
             types:
                 link: false
 
-            # Invalidate dependent elements when a document changes (disabled by default)
+            # Invalidate dependent elements when a document changes (disabled by default).
+            # Note: a dependent element type must also be enabled above for invalidation to take effect.
             invalidate_dependencies:
                 enabled: true
                 types:
                     objects: true
 
-            # Unless you disable documents completely
+            # Or disable documents completely (mutually exclusive with the options above)
             enabled: false
 
         objects:
@@ -45,15 +47,16 @@ neusta_pimcore_http_cache:
             classes:
                 MyDataObjectClass: false
 
-            # Invalidate dependent elements when an object changes (disabled by default)
+            # Invalidate dependent elements when an object changes (disabled by default).
+            # Note: a dependent element type must also be enabled above for invalidation to take effect.
             invalidate_dependencies:
                 enabled: true
                 types:
                     objects: true
                     documents: true
                     assets: true
 
-            # Unless you disable data objects completely
+            # Or disable data objects completely (mutually exclusive with the options above)
             enabled: false
 
     # Enable/disable cache handling for custom cache types

doc/3-pimcore-elements.md

@@ -92,9 +92,12 @@ Dependent element invalidation — traversing Pimcore's dependency graph to also
 
 The dependency graph is one level deep: only elements that directly reference the changed element are invalidated, not transitive dependencies.
 
+> **Note:** For a dependent element type to actually be invalidated, it must also be enabled in the main `elements` configuration. For example, setting `objects.invalidate_dependencies.types.documents: true` has no effect if `documents` is disabled — the cache tag will be silently dropped.
+
 ### Enable dependent invalidation for objects
 
-The most common use case is invalidating documents and other objects that reference a changed data object:
+The most common use case is invalidating documents and other objects that reference a changed data object.
+The listed dependent types (`documents`, `objects`) must also be enabled in the `elements` configuration:
 
 ```yaml
 neusta_pimcore_http_cache:
@@ -106,11 +109,13 @@ neusta_pimcore_http_cache:
                     documents: true  # invalidate documents that reference the object
                     objects: true    # invalidate objects that reference the object
                     assets: false    # leave assets out (default)
+        documents: true  # must be enabled for document invalidation to take effect
 ```
 
 ### Enable dependent invalidation for assets
 
-If an asset (e.g. an image) is referenced by objects or documents, those can be invalidated when the asset changes:
+If an asset (e.g. an image) is referenced by objects or documents, those can be invalidated when the asset changes.
+The listed dependent types must also be enabled in the `elements` configuration:
 
 ```yaml
 neusta_pimcore_http_cache:
@@ -121,11 +126,14 @@ neusta_pimcore_http_cache:
                 types:
                     objects: true    # invalidate objects that reference the asset
                     documents: true  # invalidate documents that reference the asset
+        objects: true    # must be enabled for object invalidation to take effect
+        documents: true  # must be enabled for document invalidation to take effect
 ```
 
 ### Enable dependent invalidation for documents
 
-If a document is referenced by other elements (e.g. an object with a document relation field), those elements can be invalidated when the document changes:
+If a document is referenced by other elements (e.g. an object with a document relation field), those elements can be invalidated when the document changes.
+The listed dependent types must also be enabled in the `elements` configuration:
 
 ```yaml
 neusta_pimcore_http_cache:
@@ -135,4 +143,5 @@ neusta_pimcore_http_cache:
                 enabled: true
                 types:
                     objects: true  # invalidate objects that reference the document
+        objects: true  # must be enabled for object invalidation to take effect
 ```

src/Element/InvalidateElementListener.php

@@ -25,20 +25,16 @@ public function onUpdate(ElementEventInterface $event): void
             return;
         }
 
-        $element = $event->getElement();
-
-        $this->invalidateElement($element);
-
-        $type = ElementType::tryFrom($element->getType());
-        if ($type !== null && $this->isDependencyTraversalEnabled($type)) {
-            $this->invalidateDependencies($element->getDependencies(), $type);
-        }
+        $this->invalidateWithDependencies($event->getElement());
     }
 
     public function onDelete(ElementEventInterface $event): void
     {
-        $element = $event->getElement();
+        $this->invalidateWithDependencies($event->getElement());
+    }
 
+    private function invalidateWithDependencies(ElementInterface $element): void
+    {
         $this->invalidateElement($element);
 
         $type = ElementType::tryFrom($element->getType());