Skip to content

Commit 64b2791

Browse files
authored
Merge pull request #304 from teamterning/303-feat
[Feat] #303 - 필터링 μž¬μ„€μ • μ•°ν”Œ μ‹¬μ—ˆμŠ΅λ‹ˆλ‹€.
2 parents 837ee37 + b0678b2 commit 64b2791

3 files changed

Lines changed: 10 additions & 22 deletions

File tree

β€ŽTerning-iOS/Terning-iOS/Presentation/FilteringSetting/FilteringView/ViewController/FilteringViewController.swiftβ€Ž

Lines changed: 7 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -201,26 +201,14 @@ extension FilteringViewController {
201201
let saveButtonTap = saveButton.rx.tap
202202
.do(
203203
onNext: {
204-
if planVC.checkBoxState.value {
205-
self.track(
206-
eventName: .clickHomeFilteringSave,
207-
eventProperties: [
208-
"jobType": UserFilteringData.shared.jobType,
209-
"planSaveAll": true
210-
].compactMapValues { $0 }
211-
)
204+
if self.segmentControl.selectedSegmentIndex == 0 {
205+
self.track( eventName: .clickFilteringJobSave)
212206
} else {
213-
self.track(
214-
eventName: .clickHomeFilteringSave,
215-
eventProperties: [
216-
"grade": UserFilteringData.shared.grade,
217-
"jobType": UserFilteringData.shared.jobType,
218-
"planSaveAll": false,
219-
"startMonth": UserFilteringData.shared.startMonth,
220-
"startYear": UserFilteringData.shared.startYear,
221-
"workingPeriod": UserFilteringData.shared.workingPeriod
222-
].compactMapValues { $0 }
223-
)
207+
if planVC.checkBoxState.value {
208+
self.track(eventName: .clickFilteringPlanSaveAll)
209+
} else {
210+
self.track(eventName: .clickFilteringPlanSaveCustom)
211+
}
224212
}
225213
}
226214
)

β€ŽTerning-iOS/Terning-iOS/Presentation/Home/ViewController/HomeViewController.swiftβ€Ž

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -347,8 +347,6 @@ extension HomeViewController: StickyHeaderCellDelegate {
347347
self.sortAndPageSubject.onNext((apiParameter, currentPage))
348348
}.disposed(by: disposeBag)
349349

350-
track(eventName: .clickHomeFilteringSave)
351-
352350
self.present(filterSettingVC, animated: true)
353351
}
354352
}

β€ŽTerning-iOS/Terning-iOS/Resource/Amplitude/AmplitudeEventType.swiftβ€Ž

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,9 @@ public enum AmplitudeEventType: String {
1818
case clickOnboardingCompleted = "click_onboarding_completed" // μ˜¨λ³΄λ”© μ™„λ£Œ μŠ€ν”Œλž˜μ‰¬_맞좀곡고 λ³΄λŸ¬κ°€κΈ°
1919

2020
// ν™ˆ ν™”λ©΄ 이벀트
21-
case clickHomeFilteringSave = "click_home_filtering_save" // ν™ˆ_필터링
21+
case clickFilteringJobSave = "click_filtering_job_save" // ν™ˆ_직무 필터링 μ €μž₯
22+
case clickFilteringPlanSaveCustom = "click_filtering_plan_save_custom" // ν™ˆ_κ³„νš 필터링 μ €μž₯
23+
case clickFilteringPlanSaveAll = "click_filtering_plan_save_all" // ν™ˆ_κ³„νš 필터링 없이 λͺ¨λ“  곡고 보기 μ €μž₯.
2224

2325
case scrollHome = "scroll_home" // ν™ˆ_리슀트 ν•˜λ‹¨κΉŒμ§€ μŠ€ν¬λ‘€ν•œ 횟수
2426
case clickInOrderOfDeadline = "click_in_order_of_deadline" // ν™ˆ_μ •λ ¬_μ±„μš© 마감 이λ₯Έ 순

0 commit comments

Comments
Β (0)