fix: address code review - actor guard, article author username in payload, correct deep links

Agent-Logs-Url: https://github.com/techdiary-dev/techdiary.dev/sessions/a4d2f56f-8ea0-484d-883e-4aa0cce5a9cc

Co-authored-by: shoaibsharif <29075110+shoaibsharif@users.noreply.github.com>

Author: Copilot

src/app/dashboard/notifications/page.tsx

@@ -70,7 +70,10 @@ function notificationLink(
     (type === "COMMENT_ON_ARTICLE" || type === "REACTION_ON_ARTICLE") &&
     payload.article_handle
   ) {
-    return `/article/${payload.article_handle}`;
+    const base = payload.article_author_username
+      ? `/@${payload.article_author_username}/${payload.article_handle}`
+      : `/@${payload.article_handle}`;
+    return base;
   }
   if (type === "COMMENT_ON_GIST" && payload.gist_id) {
     return `/gists/${payload.gist_id}`;
@@ -79,7 +82,10 @@ function notificationLink(
     (type === "REPLY_TO_COMMENT" || type === "REACTION_ON_COMMENT") &&
     payload.article_handle
   ) {
-    return `/article/${payload.article_handle}`;
+    const base = payload.article_author_username
+      ? `/@${payload.article_author_username}/${payload.article_handle}`
+      : `/@${payload.article_handle}`;
+    return base;
   }
   return "#";
 }

src/backend/models/domain-models.ts

@@ -275,6 +275,7 @@ export interface NotificationPayload {
   article_id?: string;
   article_handle?: string;
   article_title?: string;
+  article_author_username?: string;
   comment_id?: string;
   gist_id?: string;
   reaction_type?: string;

src/backend/services/comment.action.ts

@@ -53,10 +53,18 @@ export const createMyComment = async (
       });
       if (!article) throw new ActionException("Resource not found");
       notificationRecipientId = article.author_id;
+      const [articleAuthor] = await persistenceRepository.user.find({
+        where: eq("id", article.author_id),
+        limit: 1,
+        columns: ["id", "username"],
+      });
       notificationPayload = {
         article_id: article.id,
         article_handle: article.handle,
         article_title: article.title,
+        ...(articleAuthor?.username
+          ? { article_author_username: articleAuthor.username }
+          : {}),
       };
       break;
     }

src/backend/services/reaction.actions.ts

@@ -122,6 +122,8 @@ async function sendReactionNotification({
     columns: ["id", "name", "username"],
   });
 
+  if (!actor) return;
+
   if (resourceType === "ARTICLE") {
     const [article] = await persistenceRepository.article.find({
       where: eq("id", resourceId),
@@ -133,6 +135,14 @@ async function sendReactionNotification({
       payload.article_id = article.id;
       payload.article_handle = article.handle;
       payload.article_title = article.title;
+      const [articleAuthor] = await persistenceRepository.user.find({
+        where: eq("id", article.author_id),
+        limit: 1,
+        columns: ["id", "username"],
+      });
+      if (articleAuthor?.username) {
+        payload.article_author_username = articleAuthor.username;
+      }
     }
   } else if (resourceType === "COMMENT") {
     const [comment] = await persistenceRepository.comment.find({
@@ -159,8 +169,8 @@ async function sendReactionNotification({
           : "REACTION_ON_COMMENT",
       payload: {
         ...payload,
-        actor_name: actor?.name,
-        actor_username: actor?.username,
+        actor_name: actor.name,
+        actor_username: actor.username,
       },
     },
   });

src/lib/inngest.ts

@@ -18,6 +18,7 @@ export const notificationEventSchema = z.object({
       article_id: z.string().optional(),
       article_handle: z.string().optional(),
       article_title: z.string().optional(),
+      article_author_username: z.string().optional(),
       comment_id: z.string().optional(),
       gist_id: z.string().optional(),
       reaction_type: z.string().optional(),