chore: fix new rubocop lints (#398)

chris-olszewski · web-flow · commit 4c2f6ad53ee2 · 2026-03-10T14:13:28.000-04:00
* chore: fix new rubocop lints

* chore: add back comments
diff --git a/temporalio/lib/temporalio/internal/bridge/client.rb b/temporalio/lib/temporalio/internal/bridge/client.rb
@@ -16,16 +16,14 @@ class Client
           :tls, # Optional
           :rpc_retry,
           :keep_alive, # Optional
-          :http_connect_proxy, # Optional
-          keyword_init: true
+          :http_connect_proxy # Optional
         )
 
         TLSOptions = Struct.new(
           :client_cert, # Optional
           :client_private_key, # Optional
           :server_root_ca_cert, # Optional
-          :domain, # Optional
-          keyword_init: true
+          :domain # Optional
         )
 
         RPCRetryOptions = Struct.new(
@@ -34,21 +32,18 @@ class Client
           :multiplier,
           :max_interval,
           :max_elapsed_time, # Can use 0 for none
-          :max_retries,
-          keyword_init: true
+          :max_retries
         )
 
         KeepAliveOptions = Struct.new(
           :interval,
-          :timeout,
-          keyword_init: true
+          :timeout
         )
 
         HTTPConnectProxyOptions = Struct.new(
           :target_host,
           :basic_auth_user, # Optional
-          :basic_auth_pass, # Optional,
-          keyword_init: true
+          :basic_auth_pass # Optional
         )
 
         def self.new(runtime, options)
diff --git a/temporalio/lib/temporalio/internal/bridge/runtime.rb b/temporalio/lib/temporalio/internal/bridge/runtime.rb
@@ -6,20 +6,17 @@ module Bridge
       class Runtime
         Options = Struct.new(
           :telemetry,
-          :worker_heartbeat_interval,
-          keyword_init: true
+          :worker_heartbeat_interval
         )
 
         TelemetryOptions = Struct.new(
           :logging, # Optional
-          :metrics, # Optional
-          keyword_init: true
+          :metrics # Optional
         )
 
         LoggingOptions = Struct.new(
           :log_filter,
-          :forward_to, # Optional
-          keyword_init: true
+          :forward_to # Optional
         )
 
         MetricsOptions = Struct.new(
@@ -28,8 +25,7 @@ class Runtime
           :buffered_with_size, # Optional
           :attach_service_name,
           :global_tags, # Optional
-          :metric_prefix, # Optional
-          keyword_init: true
+          :metric_prefix # Optional
         )
 
         OpenTelemetryMetricsOptions = Struct.new(
@@ -39,17 +35,15 @@ class Runtime
           :metric_temporality_delta,
           :durations_as_seconds,
           :http,
-          :histogram_bucket_overrides, # Optional
-          keyword_init: true
+          :histogram_bucket_overrides # Optional
         )
 
         PrometheusMetricsOptions = Struct.new(
           :bind_address,
           :counters_total_suffix,
           :unit_suffix,
           :durations_as_seconds,
-          :histogram_bucket_overrides, # Optional
-          keyword_init: true
+          :histogram_bucket_overrides # Optional
         )
       end
     end
diff --git a/temporalio/lib/temporalio/internal/bridge/testing.rb b/temporalio/lib/temporalio/internal/bridge/testing.rb
@@ -22,8 +22,7 @@ class EphemeralServer
             :log_format,
             :log_level,
             :extra_args,
-            :download_ttl, # Optional
-            keyword_init: true
+            :download_ttl # Optional
           )
 
           StartTestServerOptions = Struct.new(
@@ -34,8 +33,7 @@ class EphemeralServer
             :download_dest_dir, # Optional
             :port, # Optional
             :extra_args,
-            :download_ttl, # Optional
-            keyword_init: true
+            :download_ttl # Optional
           )
 
           def self.start_dev_server(runtime, options)
diff --git a/temporalio/lib/temporalio/internal/bridge/worker.rb b/temporalio/lib/temporalio/internal/bridge/worker.rb
@@ -28,56 +28,48 @@ class Worker
           :nondeterminism_as_workflow_fail,
           :nondeterminism_as_workflow_fail_for_types,
           :deployment_options,
-          :plugins,
-          keyword_init: true
+          :plugins
         )
 
         TunerOptions = Struct.new(
           :workflow_slot_supplier,
           :activity_slot_supplier,
-          :local_activity_slot_supplier,
-          keyword_init: true
+          :local_activity_slot_supplier
         )
 
         TunerSlotSupplierOptions = Struct.new(
           :fixed_size,
           :resource_based,
-          :custom,
-          keyword_init: true
+          :custom
         )
 
         TunerResourceBasedSlotSupplierOptions = Struct.new(
           :target_mem_usage,
           :target_cpu_usage,
           :min_slots,
           :max_slots,
-          :ramp_throttle,
-          keyword_init: true
+          :ramp_throttle
         )
 
         WorkerDeploymentVersion = Struct.new(
           :deployment_name,
-          :build_id,
-          keyword_init: true
+          :build_id
         )
 
         DeploymentOptions = Struct.new(
           :version,
           :use_worker_versioning,
-          :default_versioning_behavior,
-          keyword_init: true
+          :default_versioning_behavior
         )
 
         PollerBehaviorSimpleMaximum = Struct.new(
-          :simple_maximum,
-          keyword_init: true
+          :simple_maximum
         )
 
         PollerBehaviorAutoscaling = Struct.new(
           :minimum,
           :maximum,
-          :initial,
-          keyword_init: true
+          :initial
         )
 
         def self.finalize_shutdown_all(workers)
diff --git a/temporalio/lib/temporalio/internal/proto_utils.rb b/temporalio/lib/temporalio/internal/proto_utils.rb
@@ -53,7 +53,7 @@ def self.memo_to_proto_hash(hash, converter)
       def self.memo_from_proto(memo, converter)
         return nil if memo.nil? || memo.fields.size.zero? # rubocop:disable Style/ZeroLengthPredicate -- Google Maps don't have empty
 
-        memo.fields.each_with_object({}) { |(key, val), h| h[key] = converter.from_payload(val) } # rubocop:disable Style/HashTransformValues
+        memo.fields.each_with_object({}) { |(key, val), h| h[key] = converter.from_payload(val) }
       end
 
       def self.headers_to_proto(headers, converter)
@@ -75,7 +75,7 @@ def self.headers_from_proto(headers, converter)
       def self.headers_from_proto_map(headers, converter)
         return nil if headers.nil? || headers.size.zero? # rubocop:disable Style/ZeroLengthPredicate -- Google Maps don't have empty
 
-        headers.each_with_object({}) do |(key, val), h| # rubocop:disable Style/HashTransformValues
+        headers.each_with_object({}) do |(key, val), h|
           # @type var h: Hash[String, Object?]
           h[key] = converter.from_payload(val)
         end
diff --git a/temporalio/lib/temporalio/search_attributes.rb b/temporalio/lib/temporalio/search_attributes.rb
@@ -58,7 +58,7 @@ def validate_value(value)
         when IndexedValueType::TIME
           raise TypeError, 'Value of TIME key must be a Time' unless value.is_a?(Time)
         when IndexedValueType::KEYWORD_LIST
-          unless value.is_a?(Array) && value.all? { |v| v.is_a?(String) }
+          unless value.is_a?(Array) && value.all?(String)
             raise TypeError, 'Value of KEYWORD_LIST key must be an Array of String'
           end
         else
diff --git a/temporalio/lib/temporalio/worker.rb b/temporalio/lib/temporalio/worker.rb
@@ -163,7 +163,7 @@ def self._run_all_root(
     )
       # Confirm there is at least one and they are all workers
       raise ArgumentError, 'At least one worker required' if workers.empty?
-      raise ArgumentError, 'Not all parameters are workers' unless workers.all? { |w| w.is_a?(Worker) }
+      raise ArgumentError, 'Not all parameters are workers' unless workers.all?(Worker)
 
       Internal::Bridge.assert_fiber_compatibility!
 
@@ -558,12 +558,8 @@ def _initialize_from_options
       )
 
       # Collect interceptors from client and params
-      @activity_interceptors = (@options.client.options.interceptors + @options.interceptors).select do |i|
-        i.is_a?(Interceptor::Activity)
-      end
-      @workflow_interceptors = (@options.client.options.interceptors + @options.interceptors).select do |i|
-        i.is_a?(Interceptor::Workflow)
-      end
+      @activity_interceptors = (@options.client.options.interceptors + @options.interceptors).grep(Interceptor::Activity)
+      @workflow_interceptors = (@options.client.options.interceptors + @options.interceptors).grep(Interceptor::Workflow)
 
       # Cancellation for the whole worker
       @worker_shutdown_cancellation = Cancellation.new
diff --git a/temporalio/lib/temporalio/worker/workflow_replayer.rb b/temporalio/lib/temporalio/worker/workflow_replayer.rb
@@ -258,9 +258,7 @@ def initialize(
             logger: options.logger,
             data_converter: options.data_converter,
             metric_meter: options.runtime.metric_meter,
-            workflow_interceptors: options.interceptors.select do |i|
-              i.is_a?(Interceptor::Workflow)
-            end,
+            workflow_interceptors: options.interceptors.grep(Interceptor::Workflow),
             disable_eager_activity_execution: false,
             illegal_workflow_calls: options.illegal_workflow_calls,
             workflow_failure_exception_types: options.workflow_failure_exception_types,
diff --git a/temporalio/lib/temporalio/workflow/info.rb b/temporalio/lib/temporalio/workflow/info.rb
@@ -23,8 +23,7 @@ module Workflow
       :task_queue,
       :task_timeout,
       :workflow_id,
-      :workflow_type,
-      keyword_init: true
+      :workflow_type
     )
 
     # Information about the running workflow. This is immutable for the life of the workflow run.
@@ -91,8 +90,7 @@ class Info
       ParentInfo = Struct.new(
         :namespace,
         :run_id,
-        :workflow_id,
-        keyword_init: true
+        :workflow_id
       )
 
       # Information about a root of a workflow.
@@ -106,8 +104,7 @@ class Info
       #   this class or it may break in incompatible ways.
       RootInfo = Struct.new(
         :run_id,
-        :workflow_id,
-        keyword_init: true
+        :workflow_id
       )
     end
   end
diff --git a/temporalio/lib/temporalio/workflow/update_info.rb b/temporalio/lib/temporalio/workflow/update_info.rb
@@ -13,8 +13,7 @@ module Workflow
     #   class or it may break in incompatible ways.
     UpdateInfo = Struct.new(
       :id,
-      :name,
-      keyword_init: true
+      :name
     )
   end
 end
diff --git a/temporalio/test/converters/payload_converter_test.rb b/temporalio/test/converters/payload_converter_test.rb
@@ -82,9 +82,7 @@ def test_binary_proto
       # Make a new converter with all default converters except json proto so
       # that binary proto takes precedent
       converter = Temporalio::Converters::PayloadConverter::Composite.new(
-        *Temporalio::Converters::PayloadConverter.default.converters.values.reject do |conv|
-          conv.is_a?(Temporalio::Converters::PayloadConverter::JSONProtobuf)
-        end
+        *Temporalio::Converters::PayloadConverter.default.converters.values.grep_v(Temporalio::Converters::PayloadConverter::JSONProtobuf)
       )
 
       proto = Temporalio::Api::Common::V1::WorkflowExecution.new(workflow_id: 'id1')
diff --git a/temporalio/test/worker_workflow_test.rb b/temporalio/test/worker_workflow_test.rb
@@ -1201,7 +1201,7 @@ class DynamicWorkflow < Temporalio::Workflow::Definition
     workflow_raw_args
 
     def execute(*raw_args)
-      raise 'Bad arg' unless raw_args.all? { |v| v.is_a?(Temporalio::Converters::RawValue) }
+      raise 'Bad arg' unless raw_args.all?(Temporalio::Converters::RawValue)
 
       res = raw_args.map { |v| Temporalio::Workflow.payload_converter.from_payload(v.payload) }.join(' -- ')
       res = "#{Temporalio::Workflow.info.workflow_type} - #{res}"
