Skip to content

Commit 43fd80c

Browse files
committed
refactor(bottom-nav-links): use navigation-utils type guards
Replace inline property checks with shared type guard functions from navigation-utils. Add keyed each iteration for stable DOM updates when linkList changes.
1 parent 5492e6f commit 43fd80c

1 file changed

Lines changed: 7 additions & 3 deletions

File tree

src/lib/components/bottom-nav-links.svelte

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,9 @@
11
<script lang="ts">
22
import NavigationItem from '$lib/holocene/navigation/navigation-item.svelte';
3+
import {
4+
isNavDividerItem,
5+
isNavLinkItem,
6+
} from '$lib/holocene/navigation/navigation-utils';
37
import type { NavLinkListItem } from '$lib/types/global';
48
59
export let open = false;
@@ -10,10 +14,10 @@
1014
<div
1115
class="flex h-full flex-col-reverse justify-start gap-6 overflow-auto px-4 py-8"
1216
>
13-
{#each linkList as item}
14-
{#if 'divider' in item && item.divider}
17+
{#each linkList as item, i (i)}
18+
{#if isNavDividerItem(item)}
1519
<hr class="border-subtle" />
16-
{:else if 'href' in item}
20+
{:else if isNavLinkItem(item)}
1721
<NavigationItem
1822
link={item.href}
1923
label={item.label}

0 commit comments

Comments
 (0)