Skip to content

Commit b98af3f

Browse files
rnorthbsideup
authored andcommitted
Add proper test scope to Vibur and Tomcat-JDBC dependencies used for testing (#382)
* Add proper `test` scope to Vibur and Tomcat-JDBC dependencies used for testing * Update changelog * Update CHANGELOG.md
1 parent 302fa39 commit b98af3f

3 files changed

Lines changed: 5 additions & 0 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ All notable changes to this project will be documented in this file.
55
### Fixed
66
- Fixed the case when disk's size is bigger than Integer's max value (#379, #380)
77
- Fix erroneous version reference used during CI testing of shaded dependencies
8+
- Fix leakage of Vibur and Tomcat JDBC test dependencies in `jdbc-test` and `mysql` modules (#382)
89

910
### Changed
1011
- Added support for Docker networks (#372)

modules/jdbc-test/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,11 +63,13 @@
6363
<groupId>org.apache.tomcat</groupId>
6464
<artifactId>tomcat-jdbc</artifactId>
6565
<version>8.5.4</version>
66+
<scope>test</scope>
6667
</dependency>
6768
<dependency>
6869
<groupId>org.vibur</groupId>
6970
<artifactId>vibur-dbcp</artifactId>
7071
<version>9.0</version>
72+
<scope>test</scope>
7173
</dependency>
7274

7375
<dependency>

modules/mysql/pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,13 @@
4949
<groupId>org.apache.tomcat</groupId>
5050
<artifactId>tomcat-jdbc</artifactId>
5151
<version>8.5.4</version>
52+
<scope>test</scope>
5253
</dependency>
5354
<dependency>
5455
<groupId>org.vibur</groupId>
5556
<artifactId>vibur-dbcp</artifactId>
5657
<version>9.0</version>
58+
<scope>test</scope>
5759
</dependency>
5860
</dependencies>
5961
</project>

0 commit comments

Comments
 (0)