Merge pull request #6 from testica/release/1.0.1

Release/1.0.1

Author: testica

CHANGELOG.md

@@ -1,4 +1,8 @@
 # CHANGELOG
 
+## [1.0.1] - 2019-03-26
+### Fixes
+- Prevent timer execution crash from custom TextWatcher
+
 ## [1.0.0] - 2019-03-20
 - Add first stable version

README.md

@@ -19,7 +19,7 @@ Include into the build.gradle file:
 
 ```groovy
 dependencies {
-    implementation 'me.testica:codeeditor:1.0.0'
+    implementation 'me.testica:codeeditor:1.0.1'
 }
 ```
 ## Usage

codeeditor/src/main/java/me/testica/codeeditor/EditorText.kt

@@ -50,7 +50,7 @@ class EditorText(context: Context, attrs: AttributeSet): EditText(context, attrs
         // TODO: getColor is deprecated
         setBackgroundColor(resources.getColor(android.R.color.transparent))
 
-        delayedTextChanged { applySyntaxHighlight() }
+        addTextChangedListener(afterTextChanged { applySyntaxHighlight() })
     }
 
     /**

codeeditor/src/main/java/me/testica/codeeditor/Util.kt

@@ -4,7 +4,6 @@ import android.content.Context
 import android.text.Editable
 import android.text.TextWatcher
 import android.text.style.ForegroundColorSpan
-import java.util.*
 
 
 /**
@@ -15,26 +14,16 @@ fun Int.toDp(context: Context): Int {
 }
 
 /**
- * Extension TextChangedListener but with delay (1 second)
- * @param predicate editable emitted after text changed
+ * Return TextWatcher object with listener on afterTextChanged
+ * @param predicate void
  */
-fun EditorText.delayedTextChanged(predicate: ((Editable?) -> Unit)) {
-    val ms: Long = 1000
-    var timer : Timer? = null
+fun afterTextChanged(predicate: (() -> Unit)): TextWatcher {
 
-    this.addTextChangedListener(object : TextWatcher {
+   return object : TextWatcher {
         override fun beforeTextChanged(s: CharSequence?, start: Int, count: Int, after: Int) {}
         override fun onTextChanged(s: CharSequence?, start: Int, before: Int, count: Int) {}
-        override fun afterTextChanged(s: Editable?) {
-            if (timer != null) timer!!.cancel()
-            timer = Timer()
-            timer!!.schedule(object : TimerTask() {
-                override fun run() {
-                    predicate.invoke(s)
-                }
-            }, ms)
-        }
-    })
+        override fun afterTextChanged(s: Editable?) { predicate.invoke() }
+   }
 }
 
 /**

gradle.properties

@@ -23,8 +23,8 @@ _desc = Code editor android library (custom syntax highlighting, number lines, e
 _website = https://github.com/testica/codeeditor
 
 # Project variables
-_versionCode = 1
-_versionName = 1.0.0
+_versionCode = 2
+_versionName = 1.0.1
 _minSdkVersion = 15
 _targetSdkVersion = 28