Don't try to download locked exercises by default

Author: juvester

src/main/java/fi/helsinki/cs/tmc/cli/command/DownloadExercisesCommand.java

@@ -29,7 +29,7 @@ public void getOptions(Options options) {
         options.addOption("a", "all", false,
                 "Download all available exercises, including previously completed");
 
-        // Not implemented in tmc-core yet
+        // Download old submissions. Not implemented in tmc-core yet
         //options.addOption("c", "completed", false, "Download previously completed exercises");
     }
 
@@ -68,7 +68,13 @@ public void run(CommandLine args, Io io) {
         TmcCliProgressObserver progobs = new TmcCliProgressObserver(io, color1, color2);
 
         List<Exercise> exercises = TmcUtil.downloadExercises(core, filtered, progobs);
-        io.println(exercises.toString());
+        if (exercises.isEmpty()) {
+            io.println("Failed to download exercises");
+            return;
+        } else if (exercises.size() != filtered.size()) {
+            io.println(Color.colorString("Some exercises could not be downloaded",
+                    Color.AnsiColor.ANSI_RED));
+        }
 
         Path configFile = app.getWorkDir().getWorkingDirectory()
                 .resolve(stringArgs[0])
@@ -85,7 +91,9 @@ protected List<Exercise> getFilteredExercises(Course course, CommandLine args) {
 
         List<Exercise> filtered = new ArrayList<>();
         for (Exercise exercise : course.getExercises()) {
-            if (!exercise.isCompleted()) {
+            // Teachers may get a list of locked exercises but core still refuses to
+            // download them. Filter locked exercises out.
+            if (!exercise.isCompleted() && !exercise.isLocked()) {
                 filtered.add(exercise);
             }
         }

src/test/java/fi/helsinki/cs/tmc/cli/command/DownloadExercisesCommandTest.java

@@ -29,6 +29,7 @@
 import org.junit.Before;
 import org.junit.Test;
 
+import java.io.File;
 import java.io.IOException;
 import java.nio.file.Path;
 import java.nio.file.Paths;
@@ -138,7 +139,9 @@ public List<Exercise> call() throws Exception {
 
         String[] args = {"download", "course1"};
         app.run(args);
-        assertTrue(testIo.out().contains("exerciseName"));
+
+        File courseJson = tempDir.resolve("course1").resolve(".tmc.json").toFile();
+        assertTrue(courseJson.exists());
     }
 
     @Test