Skip to content

Commit 192a11a

Browse files
committed
Improve logging when posting new users to courses.mooc.fi
1 parent 3b029ff commit 192a11a

1 file changed

Lines changed: 7 additions & 6 deletions

File tree

app/models/user.rb

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -238,6 +238,7 @@ def update_password_via_courses_mooc_fi(old_password, new_password)
238238
end
239239

240240
def post_new_user_to_courses_mooc_fi(password)
241+
Rails.logger.info("Posting new user #{self.email} to courses.mooc.fi")
241242
create_url = SiteSetting.value('courses_mooc_fi_create_user_url')
242243

243244
conn = Faraday.new do |f|
@@ -260,26 +261,26 @@ def post_new_user_to_courses_mooc_fi(password)
260261
data = response.body
261262

262263
unless data.is_a?(Hash) && data['user'].present?
263-
Rails.logger.error("Creating user in courses.mooc.fi returned unexpected response for user #{self.id}: #{data}")
264-
raise "Creating user in courses.mooc.fi failed for user #{self.id}"
264+
Rails.logger.error("Creating user in courses.mooc.fi returned unexpected response for user #{self.email}: #{data}")
265+
raise "Creating user in courses.mooc.fi failed for user #{self.email}"
265266
end
266267

267268
unless data['password_set']
268-
Rails.logger.warn("Password was not set for user #{self.id} in courses.mooc.fi")
269+
Rails.logger.warn("Password was not set for user #{self.email} in courses.mooc.fi")
269270
end
270271

271-
Rails.logger.info("User #{self.id} successfully created in courses.mooc.fi")
272+
Rails.logger.info("User #{self.email} successfully created in courses.mooc.fi")
272273
true
273274

274275
rescue Faraday::ClientError => e
275276
Rails.logger.error(
276-
"Creating user in courses.mooc.fi failed for user #{self.id}: #{e.response}"
277+
"Creating user in courses.mooc.fi failed for user #{self.email}: #{e.response}"
277278
)
278279
false
279280

280281
rescue => e
281282
Rails.logger.error(
282-
"Unexpected error creating user in courses.mooc.fi for user #{self.id}: #{e.message}"
283+
"Unexpected error creating user in courses.mooc.fi for user #{self.email}: #{e.message}"
283284
)
284285
false
285286
end

0 commit comments

Comments
 (0)