Fix: Run notifications (SQLMesh#1757)

vchan · web-flow · commit 8250baa58dde · 2023-11-27T12:56:09.000-08:00
* Default to prod environment in run_start notification

* Fix run_failure notification message
diff --git a/sqlmesh/core/context.py b/sqlmesh/core/context.py
@@ -459,7 +459,7 @@ def run(
             True if the run was successful, False otherwise.
         """
         self.notification_target_manager.notify(
-            NotificationEvent.RUN_START, environment=environment
+            NotificationEvent.RUN_START, environment=environment or c.PROD
         )
         success = False
         try:
@@ -484,7 +484,7 @@ def run(
             )
         else:
             self.notification_target_manager.notify(
-                NotificationEvent.RUN_FAILURE, environment=environment
+                NotificationEvent.RUN_FAILURE, "See console logs for details."
             )
 
         return success

Original file line number	Diff line number	Diff line change
`@@ -459,7 +459,7 @@ def run(`
`459`	`459`	`True if the run was successful, False otherwise.`
`460`	`460`	`"""`
`461`	`461`	`self.notification_target_manager.notify(`
`462`		`- NotificationEvent.RUN_START, environment=environment`
	`462`	`+ NotificationEvent.RUN_START, environment=environment or c.PROD`
`463`	`463`	`)`
`464`	`464`	`success = False`
`465`	`465`	`try:`
`@@ -484,7 +484,7 @@ def run(`
`484`	`484`	`)`
`485`	`485`	`else:`
`486`	`486`	`self.notification_target_manager.notify(`
`487`		`- NotificationEvent.RUN_FAILURE, environment=environment`
	`487`	`+ NotificationEvent.RUN_FAILURE, "See console logs for details."`
`488`	`488`	`)`
`489`	`489`
`490`	`490`	`return success`