Skip to content

Commit 5354074

Browse files
ZordrakZordrak
committed
Reduce duplication, and add safety
1 parent 8d1c241 commit 5354074

9 files changed

Lines changed: 75 additions & 316 deletions

‎lib/helpers.sh‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,13 @@ export -f check_default_version;
118118
function cleanup() {
119119
log 'info' 'Performing cleanup';
120120
local pwd="$(pwd)";
121+
122+
# Safety check to ensure TFENV_CONFIG_DIR is set and not empty
123+
if [ -z "${TFENV_CONFIG_DIR:-""}" ]; then
124+
log 'error' 'TFENV_CONFIG_DIR is not set, cannot perform cleanup safely';
125+
return 1;
126+
fi;
127+
121128
log 'debug' "Deleting ${TFENV_CONFIG_DIR}/version";
122129
rm -rf "${TFENV_CONFIG_DIR}/version";
123130
log 'debug' "Deleting ${TFENV_CONFIG_DIR}/versions";

‎test/run.sh‎

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,12 @@
11
#!/usr/bin/env bash
2-
set -uo pipefail;
32

4-
####################################
5-
# Ensure we can execute standalone #
6-
####################################
7-
8-
function early_death() {
9-
echo "[FATAL] ${0}: ${1}" >&2;
10-
exit 1;
11-
};
12-
13-
if [ -z "${TFENV_ROOT:-""}" ]; then
14-
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
15-
readlink_f() {
16-
local target_file="${1}";
17-
local file_name;
18-
19-
while [ "${target_file}" != "" ]; do
20-
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
21-
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
22-
target_file="$(readlink "${file_name}")";
23-
done;
24-
25-
echo "$(pwd -P)/${file_name}";
26-
};
27-
28-
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
29-
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
30-
else
31-
TFENV_ROOT="${TFENV_ROOT%/}";
32-
fi;
33-
export TFENV_ROOT;
34-
35-
if [ -n "${TFENV_HELPERS:-""}" ]; then
36-
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
37-
else
38-
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
39-
if source "${TFENV_ROOT}/lib/helpers.sh"; then
40-
log 'debug' 'Helpers sourced successfully';
41-
else
42-
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
43-
fi;
44-
fi;
3+
# Source common test setup
4+
source "$(dirname "${0}")/test_common.sh";
455

466
#####################
477
# Begin Script Body #
488
#####################
499

50-
export PATH="${TFENV_ROOT}/bin:${PATH}";
51-
5210
errors=();
5311
if [ "${#}" -ne 0 ]; then
5412
targets="$@";

‎test/test_common.sh‎

Lines changed: 51 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,51 @@
1+
#!/usr/bin/env bash
2+
3+
# Common test setup header
4+
# Source this file at the beginning of test scripts to set up the test environment
5+
6+
set -uo pipefail;
7+
8+
####################################
9+
# Ensure we can execute standalone #
10+
####################################
11+
12+
function early_death() {
13+
echo "[FATAL] ${0}: ${1}" >&2;
14+
exit 1;
15+
};
16+
17+
if [ -z "${TFENV_ROOT:-""}" ]; then
18+
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
19+
readlink_f() {
20+
local target_file="${1}";
21+
local file_name;
22+
23+
while [ "${target_file}" != "" ]; do
24+
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
25+
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
26+
target_file="$(readlink "${file_name}")";
27+
done;
28+
29+
echo "$(pwd -P)/${file_name}";
30+
};
31+
32+
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
33+
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
34+
else
35+
TFENV_ROOT="${TFENV_ROOT%/}";
36+
fi;
37+
export TFENV_ROOT;
38+
39+
if [ -n "${TFENV_HELPERS:-""}" ]; then
40+
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
41+
else
42+
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
43+
if source "${TFENV_ROOT}/lib/helpers.sh"; then
44+
log 'debug' 'Helpers sourced successfully';
45+
else
46+
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
47+
fi;
48+
fi;
49+
50+
# Ensure local tfenv binaries take precedence
51+
export PATH="${TFENV_ROOT}/bin:${PATH}";

‎test/test_install_and_use.sh‎

Lines changed: 2 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -1,54 +1,12 @@
11
#!/usr/bin/env bash
2-
set -uo pipefail;
32

4-
####################################
5-
# Ensure we can execute standalone #
6-
####################################
7-
8-
function early_death() {
9-
echo "[FATAL] ${0}: ${1}" >&2;
10-
exit 1;
11-
};
12-
13-
if [ -z "${TFENV_ROOT:-""}" ]; then
14-
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
15-
readlink_f() {
16-
local target_file="${1}";
17-
local file_name;
18-
19-
while [ "${target_file}" != "" ]; do
20-
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
21-
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
22-
target_file="$(readlink "${file_name}")";
23-
done;
24-
25-
echo "$(pwd -P)/${file_name}";
26-
};
27-
28-
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
29-
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
30-
else
31-
TFENV_ROOT="${TFENV_ROOT%/}";
32-
fi;
33-
export TFENV_ROOT;
34-
35-
if [ -n "${TFENV_HELPERS:-""}" ]; then
36-
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
37-
else
38-
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
39-
if source "${TFENV_ROOT}/lib/helpers.sh"; then
40-
log 'debug' 'Helpers sourced successfully';
41-
else
42-
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
43-
fi;
44-
fi;
3+
# Source common test setup
4+
source "$(dirname "${0}")/test_common.sh";
455

466
#####################
477
# Begin Script Body #
488
#####################
499

50-
export PATH="${TFENV_ROOT}/bin:${PATH}";
51-
5210
test_install_and_use() {
5311
# Takes a static version and the optional keyword to install it with
5412
local k="${2-""}";

‎test/test_list.sh‎

Lines changed: 2 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,12 @@
11
#!/usr/bin/env bash
22

3-
set -uo pipefail;
4-
5-
####################################
6-
# Ensure we can execute standalone #
7-
####################################
8-
9-
function early_death() {
10-
echo "[FATAL] ${0}: ${1}" >&2;
11-
exit 1;
12-
};
13-
14-
if [ -z "${TFENV_ROOT:-""}" ]; then
15-
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
16-
readlink_f() {
17-
local target_file="${1}";
18-
local file_name;
19-
20-
while [ "${target_file}" != "" ]; do
21-
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
22-
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
23-
target_file="$(readlink "${file_name}")";
24-
done;
25-
26-
echo "$(pwd -P)/${file_name}";
27-
};
28-
29-
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
30-
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
31-
else
32-
TFENV_ROOT="${TFENV_ROOT%/}";
33-
fi;
34-
export TFENV_ROOT;
35-
36-
if [ -n "${TFENV_HELPERS:-""}" ]; then
37-
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
38-
else
39-
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
40-
if source "${TFENV_ROOT}/lib/helpers.sh"; then
41-
log 'debug' 'Helpers sourced successfully';
42-
else
43-
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
44-
fi;
45-
fi;
3+
# Source common test setup
4+
source "$(dirname "${0}")/test_common.sh";
465

476
#####################
487
# Begin Script Body #
498
#####################
509

51-
export PATH="${TFENV_ROOT}/bin:${PATH}";
52-
5310
declare -a errors=();
5411

5512
log 'info' '### List local versions';

‎test/test_symlink.sh‎

Lines changed: 5 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,19 @@
11
#!/usr/bin/env bash
22

3-
set -uo pipefail;
4-
5-
####################################
6-
# Ensure we can execute standalone #
7-
####################################
8-
9-
function early_death() {
10-
echo "[FATAL] ${0}: ${1}" >&2;
11-
exit 1;
12-
};
13-
14-
if [ -z "${TFENV_ROOT:-""}" ]; then
15-
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
16-
readlink_f() {
17-
local target_file="${1}";
18-
local file_name;
19-
20-
while [ "${target_file}" != "" ]; do
21-
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
22-
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
23-
target_file="$(readlink "${file_name}")";
24-
done;
25-
26-
echo "$(pwd -P)/${file_name}";
27-
};
28-
29-
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
30-
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
31-
else
32-
TFENV_ROOT="${TFENV_ROOT%/}";
33-
fi;
34-
export TFENV_ROOT;
35-
36-
if [ -n "${TFENV_HELPERS:-""}" ]; then
37-
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
38-
else
39-
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
40-
if source "${TFENV_ROOT}/lib/helpers.sh"; then
41-
log 'debug' 'Helpers sourced successfully';
42-
else
43-
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
44-
fi;
45-
fi;
3+
# Source common test setup
4+
source "$(dirname "${0}")/test_common.sh";
465

476
#####################
487
# Begin Script Body #
498
#####################
509

51-
export PATH="${TFENV_ROOT}/bin:${PATH}";
52-
5310
declare -a errors=();
5411

5512
log 'info' '### Testing symlink functionality';
5613

57-
TFENV_BIN_DIR='/tmp/tfenv-test';
58-
log 'info' "## Creating/clearing ${TFENV_BIN_DIR}"
59-
rm -rf "${TFENV_BIN_DIR}" && mkdir "${TFENV_BIN_DIR}";
14+
TFENV_BIN_DIR="$(mktemp -d)";
15+
log 'info' "## Using temporary directory ${TFENV_BIN_DIR}";
16+
trap 'rm -rf "${TFENV_BIN_DIR}"' EXIT;
6017
log 'info' "## Symlinking ${TFENV_ROOT}/bin/* into ${TFENV_BIN_DIR}";
6118
ln -s "${TFENV_ROOT}"/bin/* "${TFENV_BIN_DIR}";
6219

‎test/test_uninstall.sh‎

Lines changed: 2 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,55 +1,12 @@
11
#!/usr/bin/env bash
22

3-
set -uo pipefail;
4-
5-
####################################
6-
# Ensure we can execute standalone #
7-
####################################
8-
9-
function early_death() {
10-
echo "[FATAL] ${0}: ${1}" >&2;
11-
exit 1;
12-
};
13-
14-
if [ -z "${TFENV_ROOT:-""}" ]; then
15-
# http://stackoverflow.com/questions/1055671/how-can-i-get-the-behavior-of-gnus-readlink-f-on-a-mac
16-
readlink_f() {
17-
local target_file="${1}";
18-
local file_name;
19-
20-
while [ "${target_file}" != "" ]; do
21-
cd "$(dirname ${target_file})" || early_death "Failed to 'cd \$(dirname ${target_file})' while trying to determine TFENV_ROOT";
22-
file_name="$(basename "${target_file}")" || early_death "Failed to 'basename \"${target_file}\"' while trying to determine TFENV_ROOT";
23-
target_file="$(readlink "${file_name}")";
24-
done;
25-
26-
echo "$(pwd -P)/${file_name}";
27-
};
28-
29-
TFENV_ROOT="$(cd "$(dirname "$(readlink_f "${0}")")/.." && pwd)";
30-
[ -n ${TFENV_ROOT} ] || early_death "Failed to 'cd \"\$(dirname \"\$(readlink_f \"${0}\")\")/..\" && pwd' while trying to determine TFENV_ROOT";
31-
else
32-
TFENV_ROOT="${TFENV_ROOT%/}";
33-
fi;
34-
export TFENV_ROOT;
35-
36-
if [ -n "${TFENV_HELPERS:-""}" ]; then
37-
log 'debug' 'TFENV_HELPERS is set, not sourcing helpers again';
38-
else
39-
[ "${TFENV_DEBUG:-0}" -gt 0 ] && echo "[DEBUG] Sourcing helpers from ${TFENV_ROOT}/lib/helpers.sh";
40-
if source "${TFENV_ROOT}/lib/helpers.sh"; then
41-
log 'debug' 'Helpers sourced successfully';
42-
else
43-
early_death "Failed to source helpers from ${TFENV_ROOT}/lib/helpers.sh";
44-
fi;
45-
fi;
3+
# Source common test setup
4+
source "$(dirname "${0}")/test_common.sh";
465

476
#####################
487
# Begin Script Body #
498
#####################
509

51-
export PATH="${TFENV_ROOT}/bin:${PATH}";
52-
5310
declare -a errors=();
5411

5512
function test_uninstall() {

0 commit comments

Comments
 (0)