Merge pull request #44 from VisualTesting/feature/confirm

Implementing confirm.

Author: elicwhite

server/controllers/api.js

@@ -207,7 +207,72 @@ Api.prototype = {
   },
 
   confirm: function(req, res) {
-    throw new Error('not implemented');
+    var params = req.body;
+
+    var project = params.project;
+    var build = params.build;
+
+    if (!project || !build) {
+      res.status(400).json({
+        status: 'failure',
+        message: 'invalid arguments'
+      });
+
+      return;
+    }
+
+    storage.hasProject(project)
+    .then(function(projectExists) {
+      if (!projectExists) {
+        res.status(400).json({
+          status: 'failure',
+          message: 'unknown project'
+        });
+
+        return;
+      }
+
+      storage.hasBuild({
+        project: project,
+        build: build
+      })
+      .then(function(buildExists) {
+        if (!buildExists) {
+          res.status(400).json({
+            status: 'failure',
+            message: 'unknown build'
+          });
+
+          return;
+        }
+
+        var info;
+
+        return storage.getBuildInfo({
+          project: project,
+          build: build
+        })
+        .then(function(buildInfo) {
+          buildInfo.status = 'approved';
+          info = buildInfo;
+
+          buildInfo.project = project;
+
+          return storage.updateBuildInfo(buildInfo);
+        })
+        .then(function() {
+          res.status(200).json({
+            status: 'success'
+          });
+
+          actions.setBuildStatus({
+            project: project,
+            sha: info.head,
+            status: 'success'
+          });
+        });
+      });
+    });
   },
 
   getImage: function(req, res) {

server/routes.js

@@ -130,7 +130,8 @@ module.exports = function(options) {
   /*
   Approve a build
   POST Params
-  - id
+  - project string
+  - build string
   Response:
   {
       status: "success"

server/utils/storage.js

@@ -234,9 +234,9 @@ var Storage = {
     assert.isObject(options);
     assert.isString(options.project);
     assert.isString(options.build);
-    assert.include(['success', 'failed'], options.status);
+    assert.isString(options.status);
 
-    if (options.status === 'failed') {
+    if (options.diffs) {
       assert.isObject(options.diffs);
     }
 
@@ -253,12 +253,7 @@ var Storage = {
     })
     .then(function(data) {
       data.status = status;
-
-      if (status === 'success') {
-        delete data.diffs;
-      } else if (status === 'failed') {
-        data.diffs = diffs;
-      }
+      data.diffs = diffs;
 
       return fs.outputJSONAsync(buildFile, data);
     });

test/api-test.js

@@ -517,6 +517,111 @@ describe('module/api', function() {
     });
   });
 
+  describe('#confirm', function() {
+    describe('with unknown project', function() {
+      it('should 400 with message', function() {
+        storageStub.hasProject = this.sinon.stub().resolves(false);
+
+        return api.post('/api/confirm')
+        .send({
+          project: 'project',
+          build: 'build'
+        })
+        .expect(400)
+        .expect(function(data) {
+          var body = data.body;
+          assert.equal(body.status, 'failure');
+          assert.equal(body.message, 'unknown project');
+        });
+      });
+    });
+
+    describe('with unknown build', function() {
+      it('should 400 with message', function() {
+        storageStub.hasProject = this.sinon.stub().resolves(true);
+        storageStub.hasBuild = this.sinon.stub().resolves(false);
+
+        return api.post('/api/confirm')
+        .send({
+          project: 'project',
+          build: 'build'
+        })
+        .expect(400)
+        .expect(function(data) {
+          var body = data.body;
+          assert.equal(body.status, 'failure');
+          assert.equal(body.message, 'unknown build');
+        });
+      });
+    });
+
+    describe('with known project and build', function() {
+      var stub;
+      var buildInfo;
+
+      beforeEach(function() {
+        buildInfo = {
+          project: 'project',
+          head: 'head',
+          status: 'failed',
+          diffs: {
+            'Chrome 28': [
+              'homepage.navbar.700.png',
+              'homepage.navbar.1300.png',
+              'homepage.search.700.png',
+              'homepage.search.1300.png'
+            ],
+            'IE 8': [
+                'homepage.navbar.700.png',
+                'homepage.search.700.png'
+            ]
+          }
+        };
+
+        storageStub.hasProject = this.sinon.stub().resolves(true);
+        storageStub.hasBuild = this.sinon.stub().resolves(true);
+        storageStub.updateBuildInfo = this.sinon.stub().resolves();
+        storageStub.getBuildInfo = this.sinon.stub().resolves(buildInfo);
+
+        instance = api.post('/api/confirm')
+        .send({
+          project: 'project',
+          build: 'build'
+        });
+      });
+
+      it('should be 200 with success', function() {
+        return instance
+        .expect(200)
+        .expect(function(data) {
+          var body = data.body;
+          assert.equal(body.status, 'success');
+        });
+      });
+
+      it('should call storage.updateBuildInfo', function() {
+        return instance.expect(function() {
+          buildInfo.status = 'approved';
+
+          assert.calledOnce(storageStub.updateBuildInfo.withArgs(buildInfo));
+        });
+      });
+
+      it('should call actions.setBuildStatus', function() {
+        return instance
+        .expect(function() {
+          assert.calledOnce(actionsStub.setBuildStatus
+            .withArgs({
+              project: 'project',
+              sha: 'head',
+              status: 'success'
+            })
+          );
+        });
+      });
+    });
+  });
+
   describe('#getImage', function() {
     it('should call getImage', function() {
       storageStub.getImage = this.sinon.stub();