Merge pull request #43 from VisualTesting/fix/diffs

Changing diff to diffs on getBuildInfo

Author: elicwhite

server/routes.js

@@ -102,7 +102,7 @@ module.exports = function(options) {
   }
 
   {
-      id: 203,
+      build: 203,
       head: {SHA},
       base: {SHA},
       status: "success" // either "failed", "success"

server/utils/storage.js

@@ -225,11 +225,11 @@ var Storage = {
     assert.include(['success', 'failed'], options.status);
 
     if (options.status === 'failed') {
-      assert.isObject(options.diff);
+      assert.isObject(options.diffs);
     }
 
     var status = options.status;
-    var diff = options.diff;
+    var diffs = options.diffs;
     var buildFile = path.join(getBuildsPath(options.project), options.build, 'build.json');
 
     return assert.eventually.isTrue(this.hasBuild({
@@ -243,9 +243,9 @@ var Storage = {
       data.status = status;
 
       if (status === 'success') {
-        delete data.diff;
+        delete data.diffs;
       } else if (status === 'failed') {
-        data.diff = diff;
+        data.diffs = diffs;
       }
 
       return fs.outputJSONAsync(buildFile, data);

test/storage-test.js

@@ -651,13 +651,13 @@ describe('module/storage', function() {
         });
       });
 
-      it('should not have a diff', function() {
+      it('should not have diffs', function() {
         return storage.getBuildInfo({
           project: projectId,
           build: buildId
         })
         .then(function(buildInfo) {
-          assert.isUndefined(buildInfo.diff);
+          assert.isUndefined(buildInfo.diffs);
         });
       });
     });
@@ -670,7 +670,7 @@ describe('module/storage', function() {
           project: projectId,
           build: buildId,
           status: 'failed',
-          diff: {
+          diffs: {
             Chrome: ['image1.png,', 'image2.png'],
             Firefox: ['image1.png']
           }
@@ -689,13 +689,13 @@ describe('module/storage', function() {
         });
       });
 
-      it('should have a diff', function() {
+      it('should have diffs', function() {
         return storage.getBuildInfo({
           project: projectId,
           build: buildId
         })
         .then(function(buildInfo) {
-          assert.deepEqual(buildInfo.diff, newBuildInfo.diff);
+          assert.deepEqual(buildInfo.diffs, newBuildInfo.diffs);
         });
       });
     });