Merge pull request #92 from ai/export-const2

Fix ignoring export const cases

Author: cowboyd

.changes/fix-export-const2.md

@@ -0,0 +1,5 @@
+---
+"eslint-plugin-prefer-let": patch
+---
+
+Fix ignoring `export const` cases

packages/eslint-plugin-prefer-let/lib/rules/prefer-let.js

@@ -122,7 +122,7 @@ module.exports = {
           });
         } else if (node.kind === 'const') {
           if (isTopLevelScope(node)) {
-            if (forceUpperCaseConst && !allDeclaratorsUpperCase(node)) {
+            if (forceUpperCaseConst && !allDeclaratorsUpperCase(node) && !(node.parent && node.parent.type === 'ExportNamedDeclaration')) {
               let constToken = sourceCode.getFirstToken(node);
               context.report({
                 message: '`const` declaration for non-constant names at top-level scope. Use `let` or rename to UPPER_CASE',

packages/eslint-plugin-prefer-let/tests/lib/rules/prefer-let.js

@@ -82,6 +82,11 @@ ruleTester.run("prefer-let", rule, {
       code: "export const FOO_BAR = 'baz';",
       options: [{ forceUpperCaseConst: true }]
     },
+    // forceUpperCaseConst: export const with non-upper-case name does not create an issue
+    {
+      code: "export const foo = 'bar';",
+      options: [{ forceUpperCaseConst: true }]
+    },
     // forceUpperCaseConst: let with non-upper-case at top level is valid
     {
       code: "let fooBar = 'baz';",
@@ -154,14 +159,6 @@ ruleTester.run("prefer-let", rule, {
         message: "`const` declaration for non-constant names at top-level scope. Use `let` or rename to UPPER_CASE"
       }]
     },
-    {
-      code: "export const AlsoObject = Object;",
-      output: "export let AlsoObject = Object;",
-      options: [{ forceUpperCaseConst: true }],
-      errors: [{
-        message: "`const` declaration for non-constant names at top-level scope. Use `let` or rename to UPPER_CASE"
-      }]
-    },
     // forceUpperCaseConst: let with UPPER_CASE at top level is invalid
     {
       code: "let FOO_BAR = 'baz';",