Skip to content

Add injectable localization hook for InterfaceKit strings #470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michele-theleftbit merged 3 commits into from
May 13, 2026
Merged

Add injectable localization hook for InterfaceKit strings #470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
42d9ddc
Add injectable localization hook for InterfaceKit strings
michele-theleftbit May 13, 2026
98055ab
update simulator
michele-theleftbit May 13, 2026
716dcd2
Apply suggestion from @piercifani
piercifani May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
with:
lfs: true
- name: Test BSWInterfaceKit iOS
run: set -o pipefail && xcodebuild -scheme BSWInterfaceKit -destination "platform=iOS Simulator,name=iPhone 17,OS=26.4.1" test | xcbeautify --renderer github-actions
run: set -o pipefail && xcodebuild -scheme BSWInterfaceKit -destination "platform=iOS Simulator,name=iPhone 17,OS=latest" test | xcbeautify --renderer github-actions

macos-build:
runs-on: mobile
Expand Down
16 changes: 15 additions & 1 deletion Sources/BSWInterfaceKit/Extensions/Localizable.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@ import Foundation

extension String {
var localized: String {
return NSLocalizedString(self, bundle: Bundle.main, comment: "")
LocalizationService.localized(self)
}
}

public enum LocalizationService {
/// Default localization hook used by InterfaceKit strings.
///
/// On Apple platforms, looking up strings from `Bundle.main` works because the
/// host app owns the main bundle and ships its localized resources there.
/// Other runtimes do not necessarily have an equivalent app bundle lookup.
/// Android/Skip apps, in particular, should inject this closure from the host
/// app so strings are resolved through the app localization system, resources,
/// or any runtime translation provider.
public static nonisolated(unsafe) var localized: (String) -> String = {

@piercifani piercifani May 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a great comment, I can tell the LLM loves you

@michele-theleftbit michele-theleftbit May 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI is amazing when you give it the right words 😄

NSLocalizedString($0, bundle: .main, comment: "")
}
}
Loading