fix build with recent versions of clang. Small fixes

Author: thelfer

include/MGIS/Behaviour/MaterialStateManager.hxx

@@ -452,10 +452,12 @@ namespace mgis::behaviour {
    * group.
    *
    * \param[in] ctx: execution context
+   * \param[in] b: behaviour
    * \param[in] g: group
    */
   MGIS_EXPORT [[nodiscard]] std::optional<MaterialStateManagerRestoreOptions>
   getGreedyMaterialStateManagerRestoreOptions(Context&,
+					      const Behaviour&,
                                               const H5::Group&) noexcept;
   /*!
    * \brief restore a `MaterialStateManager` from a HDF5 group

include/MGIS/Config-c.h

@@ -46,26 +46,41 @@
 #define MGIS_VISIBILITY_EXPORT __declspec(dllexport)
 #define MGIS_VISIBILITY_LOCAL
 #else /* defined _WIN32 || defined __CYGWIN__ */
-#if (defined __GNUC__) && (!defined __INTEL_COMPILER)
+#if (defined __GNUC__) && (!defined __INTEL_COMPILER) && \
+    (!defined __NVCOMPILER) && (!defined __clang__)
 #if __GNUC__ >= 4
-#define MGIS_VISIBILITY_IMPORT __attribute__((visibility("default")))
-#define MGIS_VISIBILITY_EXPORT __attribute__((visibility("default")))
-#define MGIS_VISIBILITY_LOCAL __attribute__((visibility("hidden")))
-#else /* __GNUC__ >= 4 */
+#define MGIS_VISIBILITY_IMPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_EXPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_LOCAL [[gnu::visibility("hidden")]]
+#else /*__GNUC__ >= 4 */
 #define MGIS_VISIBILITY_IMPORT
 #define MGIS_VISIBILITY_EXPORT
 #define MGIS_VISIBILITY_LOCAL
-#endif /* __GNUC__ >= 4 */
+#endif /* LIB_MGIS_CONFIG_HXX */
 #elif defined __INTEL_COMPILER
+#define MGIS_VISIBILITY_IMPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_EXPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_LOCAL [[gnu::visibility("hidden")]]
+#elif (defined __NVCOMPILER)
 #define MGIS_VISIBILITY_IMPORT __attribute__((visibility("default")))
 #define MGIS_VISIBILITY_EXPORT __attribute__((visibility("default")))
 #define MGIS_VISIBILITY_LOCAL __attribute__((visibility("hidden")))
-#else /* defined __INTEL_COMPILER */
+#elif defined __clang__
+#if __clang_major__ >= 18
+#define MGIS_VISIBILITY_IMPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_EXPORT [[gnu::visibility("default")]]
+#define MGIS_VISIBILITY_LOCAL [[gnu::visibility("hidden")]]
+#else /* __clang_major__ >= 18 */
+#define MGIS_VISIBILITY_IMPORT __attribute__((visibility("default")))
+#define MGIS_VISIBILITY_EXPORT __attribute__((visibility("default")))
+#define MGIS_VISIBILITY_LOCAL __attribute__((visibility("hidden")))
+#endif /* __clang_major__ >= 18 */
+#else
 #define MGIS_VISIBILITY_IMPORT
 #define MGIS_VISIBILITY_EXPORT
 #define MGIS_VISIBILITY_LOCAL
-#endif /* defined __INTEL_COMPILER */
-#endif /* defined _WIN32 || defined _WIN64 ||defined __CYGWIN__ */
+#endif /* LIB_MGIS_CONFIG_HXX */
+#endif /* LIB_MGIS_CONFIG_HXX */
 
 #ifdef MGIS_REAL_TYPE
 /*! \brief alias to the numeric type used in the library */

src/HDF5Support.cxx

@@ -393,4 +393,4 @@ namespace mgis::utilities::hdf5 {
     return false;
   }  // end of restore
 
-}  // end of namespace mgis::utilities::hdf5
+}  // end of namespace mgis::utilities::hdf5

src/MaterialStateManager.cxx

@@ -877,7 +877,6 @@ namespace mgis::behaviour {
     if ((opts.restore_stored_energies) && (s.b.computesStoredEnergy)) {
       if (!read(ctx, s.stored_energies, g, "stored_energies")) {
         return ctx.registerErrorMessage("restoring stored energies failed");
-        return false;
       }
     }
     if ((opts.restore_dissipated_energies) && (s.b.computesDissipatedEnergy)) {

tests/ErrorBacktraceTest.cxx

@@ -1,3 +1,4 @@
+#include <utility>
 #include <string_view>
 #include "MGIS/Raise.hxx"
 #include "MGIS/ErrorBacktrace.hxx"
@@ -51,7 +52,7 @@ int main() {
     try {
       raise("invalid argument");
     } catch (...) {
-      registerExceptionInErrorBacktrace(e);
+      std::ignore = registerExceptionInErrorBacktrace(e);
     }
     expect_eq(e.getRawErrorMessage(), "invalid argument");
   }  // end of ConstructTest
@@ -62,9 +63,9 @@ int main() {
   }  // end of ConstructTest
   {
     ErrorBacktrace e;
-    e.registerErrorMessage(
+    std::ignore = e.registerErrorMessage(
         "first error message\nwith details on multiple lines");
-    e.registerErrorMessage("parent error message");
+    std::ignore = e.registerErrorMessage("parent error message");
     expect_eq(e.getRawErrorMessage(),
               "parent error message\n"
               "* first error message\n"